RFC: remove 'oldfind'?

2021-09-19 Thread Bernhard Voelker
The FTS-based find is the default for a long time; oldfind has not been installed since 4.5.18 (2015), and was only just used in tests. Any objection to remove 'oldfind'? Have a nice day, BernyFrom 5768a03ddfb5e18b1682e339d6cdd24ff721c510 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Su

[PATCH 4/4] find: improve readability of --help output

2021-09-19 Thread Bernhard Voelker
* find/util.c (usage): Start sentences with upper case. Add extra newlines to put each section (operators, options, tests, and actions) on its own line. Move the typical generic options --help and --version to the end. * NEWS (Documentation Changes): Mention the change. --- NEWS| 3 +++ f

[PATCH 3/4] maint: generate ChangeLog with --no-cluster

2021-09-19 Thread Bernhard Voelker
* build-aux/gen-changelog.sh: Call gitlog-to-changelog with the --no-cluster option. The resulting ChangeLog reads better, because each commit get its own date/author line. --- build-aux/gen-changelog.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/build-aux/gen-changelog.sh b/build-aux/ge

[PATCH 2/4] find: remove redundant function error_severity and avoid magic numbers

2021-09-19 Thread Bernhard Voelker
The struct state field exit_status is only set to 0 (EXIT_SUCCESS) or to 1 (EXIT_FAILURE) throughout the code. Therefore, remove the more complicated wrapper function error_severity which was only used in very few cases anyway. While at it, replace the above magic numbers by EXIT_OKAY/EXIT_SUCCESS.

[PATCH 0/4] minor maintenance patches

2021-09-19 Thread Bernhard Voelker
Only the last one of the following patch series is user-visible, and improves the readability of `find --help`: [PATCH 1/4] maint: fix typos in comments [PATCH 2/4] find: remove redundant function error_severity and avoid [PATCH 3/4] maint: generate ChangeLog with --no-cluster [PATCH 4/4] find: im

[PATCH 1/4] maint: fix typos in comments

2021-09-19 Thread Bernhard Voelker
* find/tree.c (get_expr): Add missing closing paren. * find/util.c (insert_primary): s/insure/ensure/ (fatal_nontarget_file_error): s/isssue/issue/ * xargs/xargs.c (XargsStatusValues): s/exites/exited/ --- find/tree.c | 2 +- find/util.c | 4 ++-- xargs/xargs.c | 2 +- 3 files changed, 4 inser