Re: [PATCH] ftsfind.c: avoid buffer overflow in -D code

2018-07-07 Thread Jim Meyering
On Sat, Jul 7, 2018 at 4:13 PM, Bernhard Voelker wrote: > Reported by GCC 8.1.1: > > ftsfind.c: In function ‘get_fts_info_name’: > ftsfind.c:164:23: warning: ‘%d’ directive writing between 1 and 11 bytes into > a region of size 9 [-Wformat-overflow=] >sprintf (buf, "[%d]", info); >

[PATCH] ftsfind.c: avoid buffer overflow in -D code

2018-07-07 Thread Bernhard Voelker
Reported by GCC 8.1.1: ftsfind.c: In function ‘get_fts_info_name’: ftsfind.c:164:23: warning: ‘%d’ directive writing between 1 and 11 bytes into a region of size 9 [-Wformat-overflow=] sprintf (buf, "[%d]", info); ^~ ftsfind.c:164:7: note: ‘sprintf’ output between 4

[bug #54171] find -depth skips unreadable directories

2018-07-07 Thread Bernhard Voelker
Update of bug #54171 (project findutils): Status:None => Fixed Assigned to:None => berny ___ Follow-up Comment #4: great, pushed wit

[bug #54236] Leftover extra chars after C1 control's tty sanitization

2018-07-07 Thread Egmont Koblinger
Follow-up Comment #6, bug #54236 (project findutils): Thanks guys! Probably both patches are okay, but I cannot test them now, so I just trust you that they're indeed correct. Nit: I don't get why you call it a "workaround" in the commit message. Isn't this the correct fix?

[bug #54236] Leftover extra chars after C1 control's tty sanitization

2018-07-07 Thread Bernhard Voelker
Follow-up Comment #5, bug #54236 (project findutils): Indeed, however I'd rather fix the place which introduced the problem: in qmark_chars(). Patch attached. (file #44519) ___ Additional Item Attachment: File name: 0001-Shorten-output-

[bug #54263] find -L treats ENOENT and ENOTDIR differently

2018-07-07 Thread Tavian Barnes
URL: Summary: find -L treats ENOENT and ENOTDIR differently Project: findutils Submitted by: tavianator Submitted on: Sat 07 Jul 2018 07:39:49 PM UTC Category: find Sev

[bug #54262] -printf %Y doesn't output N for broken links

2018-07-07 Thread Tavian Barnes
Follow-up Comment #1, bug #54262 (project findutils): The code in print.c is /* If we would normally follow links, do not do so. * If we would normally not follow links, do so. */ if ((following_links () ? optionp_stat : optionl_st

[bug #54262] -printf %Y doesn't output N for broken links

2018-07-07 Thread Tavian Barnes
URL: Summary: -printf %Y doesn't output N for broken links Project: findutils Submitted by: tavianator Submitted on: Sat 07 Jul 2018 06:54:23 PM UTC Category: locate Se