Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread Paul Eggert
Kamil Dudka wrote: While I respect your opinion about removing this debugging facility upstream, the -noleaf option stays implemented in Fedora. That shouldn't be a problem. As I mentioned, findutils can still support -noleaf even when using unmodified Gnulib. Just have -noleaf turn off FTS_CW

Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread Kamil Dudka
On Tuesday, July 25, 2017 09:10:09 Paul Eggert wrote: > Kamil Dudka wrote: > > Any chance to make the (still documented) -noleaf option of find work > > again? > I'm inclined to agree with Pádraig, in thinking that fts should Just Work > without the complexity of an extra option to disable an optim

Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread Paul Eggert
James Youngman wrote: I don't see FTS_CURDIR in fts_.h. Is that the right enum name? Sorry, I meant FTS_CWDFD.

Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread James Youngman
On Tue, Jul 25, 2017 at 5:10 PM, Paul Eggert wrote: > Kamil Dudka wrote: >> >> Any chance to make the (still documented) -noleaf option of find work >> again? > > > I'm inclined to agree with Pádraig, in thinking that fts should Just Work > without the complexity of an extra option to disable an o

Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread Paul Eggert
Kamil Dudka wrote: Any chance to make the (still documented) -noleaf option of find work again? I'm inclined to agree with Pádraig, in thinking that fts should Just Work without the complexity of an extra option to disable an optimization that is supposed to work. As things stand, 'find' ca

Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread Kamil Dudka
On Tuesday, July 25, 2017 02:16:30 Paul Eggert wrote: > I found some subtle bugs in Gnulib fts.c, and created a test case that > reliably fails in reiserfs due to confusion with st_nlink. I added this > test case to Gnulib and fixed the bugs I found. As far as I can see, the > only problems that sh

Re: findutils 4.6.0 v. Tru64 (strftime() v. "%F"?)

2017-07-25 Thread James Youngman
On Tue, Jul 25, 2017 at 12:40 PM, Eric Blake wrote: > Why not use gnulib's nstrftime module instead, then you can rely not > only on %F, but also on extensions like %s, regardless of libc? I don't have an in-principle objection, but I'll need to figure out if there would be any resulting behaviou

Re: findutils 4.6.0 v. Tru64 (strftime() v. "%F"?)

2017-07-25 Thread Eric Blake
On 07/23/2017 04:22 PM, James Youngman wrote: > Please try the attached patch, which should fix the problem with %F on > Tru64 and on HP-UX. Why not use gnulib's nstrftime module instead, then you can rely not only on %F, but also on extensions like %s, regardless of libc? -- Eric Blake, Princip

Several changes made to fts.c in Gnulib

2017-07-25 Thread Paul Eggert
I found some subtle bugs in Gnulib fts.c, and created a test case that reliably fails in reiserfs due to confusion with st_nlink. I added this test case to Gnulib and fixed the bugs I found. As far as I can see, the only problems that should affect findutils and coreutils are minor performance p

[bug #51506] Better support for data processing with basenames

2017-07-25 Thread Markus Elfring
Follow-up Comment #16, bug #51506 (project findutils): > I agree with James - there's no need to add yet more knobs to findutils' configure. How can any patch make a difference for which you would care also (despite of concerns for special program configurations) then? > …, you'll still be free