Re: [Findutils-patches] [PATCH] find: handle more readdir(3) errors

2016-11-01 Thread Eric Blake
On 11/01/2016 04:32 PM, Bernhard Voelker wrote: > >> However, > >>> +++ b/lib/fdleak.c > >>> - while ((dent=readdir (dir)) != NULL) - { + while (1) + >>> { + errno = 0; > > __^^ Uggh. Mail clients botched the formatting. > >>> + dent = readdir (

Re: [Findutils-patches] [PATCH] find: handle more readdir(3) errors

2016-11-01 Thread Bernhard Voelker
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/01/2016 09:06 PM, Eric Blake wrote: > On 11/01/2016 02:37 PM, Bernhard Voelker wrote: >> Similar to the FTS readdir fix in v4.6.0-72-g155c9d1, handle the last two >> unhandled readdir(3) errors. >> >> * find/pred.c (pred_empty): Do the above. *

Re: [Findutils-patches] [PATCH] find: handle more readdir(3) errors

2016-11-01 Thread Eric Blake
On 11/01/2016 02:37 PM, Bernhard Voelker wrote: > Similar to the FTS readdir fix in v4.6.0-72-g155c9d1, handle the last > two unhandled readdir(3) errors. > > * find/pred.c (pred_empty): Do the above. > * lib/fdleak.c (get_proc_max_fd): Likewise. While at it, fix the > condition to only skip "."

[PATCH] find: handle more readdir(3) errors

2016-11-01 Thread Bernhard Voelker
Similar to the FTS readdir fix in v4.6.0-72-g155c9d1, handle the last two unhandled readdir(3) errors. * find/pred.c (pred_empty): Do the above. * lib/fdleak.c (get_proc_max_fd): Likewise. While at it, fix the condition to only skip "." and ".."; previously, also other files beginning with ".." w

Re: High CPU use on BTRFS and some other details in the stable release package.

2016-11-01 Thread Bernhard Voelker
On 10/03/2016 04:30 PM, Steve wrote: > I'm not sure what was at fault here but I had excessive CPU use with > findutils after switching from EXT4 to BTRFS in Void Linux. > https://github.com/voidlinux/void-packages/issues/4829 > Is this because find isn't optimised for BTRFS, there's a problem wit

Re: find -path is posix

2016-11-01 Thread Bernhard Voelker
On 10/26/2016 06:35 AM, isabella parakiss wrote: > from find/find.1 > >> The predicate >> .B \-path >> is also supported by HP-UX >> .B find >> and will be in a forthcoming version of the POSIX standard. > > > find -path has been in posix for 8 years Thanks for the report. The attached fixes it