date:20151223

Re: a minor bug

2015-12-23 Thread James Youngman

On Wed, Dec 23, 2015 at 11:13 PM, Paul Eggert wrote: > James Youngman wrote: > >> +static FILE* fopen_cloexec_for_read_only (const char *file_name) { >> + int fd = open_cloexec (file_name, O_RDONLY); >> + return (fd < 0) ? NULL : fdopen (fd, "r"); >> +} > > > This should close fd if fdopen fails

Re: a minor bug

2015-12-23 Thread Paul Eggert

James Youngman wrote: +static FILE* fopen_cloexec_for_read_only (const char *file_name) { + int fd = open_cloexec (file_name, O_RDONLY); + return (fd < 0) ? NULL : fdopen (fd, "r"); +} This should close fd if fdopen fails, no? Also, the indentation should be fixed to be GNU-like.

Re: a minor bug

2015-12-23 Thread James Youngman

[ Moving bug-gnulib to BCC ] Thanks for the contribution. I would have simply applied your patch, but it lacked a test case to ensure that the bug doesn't come back. Hence I implemented a different bug-fix, taking advantage of a file-descriptor-leak defence already used in find. I've attached the

Re: [PATCH] Fix save_cwd/restore_cwd error diagnostics.

2015-12-23 Thread James Youngman

Applied; thanks!

Re: Proposed stable release of GNU findutils: opinions?

2015-12-23 Thread Jim Meyering

On Wed, Dec 23, 2015 at 9:45 AM, James Youngman wrote: > On Sun, Dec 20, 2015 at 5:30 PM, Andreas Metzler wrote: >> On 2015-12-18 James Youngman wrote: >>> I'm considering making a stable release (i.e. 4.6.0) of GNU findutils >>> in the next few days, essentially identical to the recent 4.5.15 >

[bug #40146] gnulib revision doesn't support musl libc

2015-12-23 Thread James Youngman

Update of bug #40146 (project findutils): Open/Closed:Open => Closed Fixed Release:None => 4.5.16 ___ Reply to this item at:

[bug #46715] testsuite error with perl 5.22, gnulib outdated

2015-12-23 Thread James Youngman

Update of bug #46715 (project findutils): Open/Closed:Open => Closed Fixed Release:None => 4.5.16 ___ Reply to this item at:

Ping: [PATCH] Fix save_cwd/restore_cwd error diagnostics.

2015-12-23 Thread Dmitry V. Levin

Ping. -- ldv pgpzI0XxJTV2r.pgp Description: PGP signature

Re: Proposed stable release of GNU findutils: opinions?

2015-12-23 Thread James Youngman

On Sun, Dec 20, 2015 at 5:30 PM, Andreas Metzler wrote: > On 2015-12-18 James Youngman wrote: >> I'm considering making a stable release (i.e. 4.6.0) of GNU findutils >> in the next few days, essentially identical to the recent 4.5.15 >> release, with a version number change. > >> What are your t

Announcing the release of findutils-4.5.16

2015-12-23 Thread James Youngman

I am pleased to announce the release of version 4.5.16 of GNU findutils. GNU findutils is a set of software tools for finding files that match certain criteria and for performing various operations on them. Findutils includes the programs "find", "xargs" and "locate". More information about findu