[PATCH 1/3] Enable sc_makefile_at_at_check; fix problems it identifies.

2011-06-11 Thread James Youngman
* lib/Makefile.am: Use $(FINDLIBOBJS) instead of @FINDLIBOBJS@. * find/Makefile.am (LDADD): Use $(FINDLIBS) instead of @FINDLIBS@. * locate/Makefile.am (updatedb): Use $(VERSION) and $(PACKAGE_NAME) instead of @VERSION@ and @PACKAGE_NAME@. * cfg.mk: remove sc_makefile_at_at_check from local-checks-

[PATCH 2/3] Eliminate .x-sc_prohibit_empty_lines_at_EOF and .x-sc_bindtextdomain

2011-06-11 Thread James Youngman
* cfg.mk: Move definition of which files we should not check to exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF, instead of .x-sc_prohibit_empty_lines_at_EOF. Move contents of .x-sc_bindtextdomain into exclude_file_name_regexp--sc_bindtextdomain. .x-sc_prohibit_empty_lines_at_EOF: Delete.

[PATCH 3/3] Eliminate remaining .x-* files.

2011-06-11 Thread James Youngman
* cfg.mk: Move more .x-* files into variables. (exclude_file_name_regexp--sc_prohibit_always_true_header_tests): Incorporate .x-sc_prohibit_always_true_header_tests. (exclude_file_name_regexp--sc_prohibit_test_minus_ao): Incorporate .x-sc_prohibit_test_minus_ao. (exclude_file_name_regexp--sc_prohib

[PATCH 2/2] Enable syntax check sc_obsolete_symbols.

2011-06-11 Thread James Youngman
(exclude_file_name_regexp--sc_obsolete_symbols): Don't check build-aux/src-sniff.py. --- ChangeLog |4 cfg.mk|6 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index c1af90d..2be836e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -17,6 +17,1

[PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses

2011-06-11 Thread James Youngman
* find/defs.h: Eliminate useless parentheses in #if. * find/find.c (safely_chdir): Likewise. * find/pred.c: Likewise. * lib/buildcmd.c: Likewise. * lib/fdleak.c: Likewise * xargs/xargs.c: Likewise. * find/parser.c: Likewise. (ISDIGIT): Simplify, and avoid undefining isascii. * cfg.mk (local-checks-

[PATCH 1/2] Improve src-sniff.py.

2011-06-11 Thread James Youngman
* build-aux/src-sniff.py: Mention that many of these checks would be better as gnulib syntax checks (since there are more flexible ways to disable these). (RegexChecker.__init__): Don't pass a spurious second "self" argument. (RegexChecker.Check): Provide a more intelligible message when complainin

[PATCH 2/2] Use stat-size macros in pred.c also.

2011-06-11 Thread James Youngman
* find/pred.c: Include stat-size. Eliminate definitions of DEV_BSIZE, ST_BLKSIZE, ST_NBLOCKS, ST_NBLOCKSIZE macros which are now in stat-size.h (yes, this is the second set of these macros we've removed). (file_sparseness): Use ST_NBLOCKS and ST_NBLOCKSIZE. * cfg.mk (local-checks-to-skip): Don't s

Re: [PATCH] Adopt the new gnulib module stat-size. * lib/listfile.c: Include "stat-size.h". Delete the DEV_BSIZE, ST_BLKSIZE, ST_NBLOCKS, ST_NBLOCKSIZE macros which are now in stat-size.h. * gnulib:

2011-06-11 Thread James Youngman
I'm going to amend that change descrtiption. Sorry about the inconvenience.

[PATCH] Adopt the new gnulib module stat-size. * lib/listfile.c: Include "stat-size.h". Delete the DEV_BSIZE, ST_BLKSIZE, ST_NBLOCKS, ST_NBLOCKSIZE macros which are now in stat-size.h. * gnulib: Updat

2011-06-11 Thread James Youngman
--- ChangeLog|9 +++ gnulib |2 +- import-gnulib.config |1 + lib/listfile.c | 65 +- 4 files changed, 12 insertions(+), 65 deletions(-) diff --git a/ChangeLog b/ChangeLog index 70d8cd4..3b23122 1006