Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread James Youngman
On Fri, May 7, 2010 at 9:21 AM, Kamil Dudka wrote: > On Friday 07 of May 2010 10:08:08 James Youngman wrote: >> Thanks for spotting this.   I can see the bug simply by inspecting >> your fix.   But, is there any kind of test case which actually >> demonstrates the problem?   If we add a relevant t

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread Kamil Dudka
On Friday 07 of May 2010 10:56:52 Kamil Dudka wrote: > > If you'd like to supply a backported "format-patch" patch against the > > 4.4.x tree, I can apply that too. > > It may sound stupid, but where can I get the upstream 4.4.x branch from? Hopefully I got the right one: $ git pull origin rel-4-

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread Kamil Dudka
On Friday 07 of May 2010 10:08:08 James Youngman wrote: > Thanks for spotting this. I can see the bug simply by inspecting > your fix. But, is there any kind of test case which actually > demonstrates the problem? If we add a relevant test we can protect > ourselves against reintroducing this

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread James Youngman
On Fri, May 7, 2010 at 9:56 AM, Kamil Dudka wrote: > On Friday 07 of May 2010 10:41:03 James Youngman wrote: > The man page says: > >    As with the -exec action, the `+' form of -execdir will build a command >    line to process more than one matched file, but any given invocation of >    comman

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread Kamil Dudka
On Friday 07 of May 2010 10:41:03 James Youngman wrote: > I have applied and pushed your patch as the two attached git patches > (if you could send your changes in "git format-patch" format in > future, ideally with a ChangeLog entry too, that would streamline > things for me). Sure, will do. > >

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread James Youngman
On Thu, May 6, 2010 at 2:03 PM, Kamil Dudka wrote: > Hello, > > attached is a patch fixing bugs of run_in_dir () which I encountered while > doing backport of #19593 for stable findutils.  Thanks in advance for > considering the patch! Thanks for spotting this. I can see the bug simply by inspe

Re: Findutils failure due to reliance /bin/echo

2010-05-07 Thread James Youngman
On Thu, May 6, 2010 at 6:32 PM, Eric Blake wrote: > On 05/06/2010 09:13 AM, Ludovic Courtès wrote: >>> Even if it is also available as a shell builtin, that does not >>> alleviate the requirement to also have it available on $PATH. >> >> echo(1) *is* available in $PATH in the build environment, ju