[bug #27563] -L breaks -execdir

2010-04-12 Thread James Youngman
Update of bug #27563 (project findutils): Status: Code Review => Fixed ___ Reply to this item at: ___

[bug #19593] -execdir .... {} + has suboptimal performance

2010-04-12 Thread James Youngman
Update of bug #19593 (project findutils): Status: Code Review => Fixed ___ Follow-up Comment #2: Fixed the in 4.5.x branch. ___ Repl

[bug #29511] fails to build on kfreebsd-*

2010-04-12 Thread James Youngman
Update of bug #29511 (project findutils): Status: Code Review => Fixed ___ Follow-up Comment #2: Fixed the in 4.5.x branch. ___ Repl

Re: [PATCH 2/3] Fix false positives for syntax check sc_prohibit_test_minus_ao.

2010-04-12 Thread James Youngman
On Mon, Apr 12, 2010 at 5:17 PM, Eric Blake wrote: > Each .x-sc* file is passed as an argument to grep -vEf, so you can use > regular expressions to not only condense the list, but to also make > adding future tests have one less place to touch: > > find/testsuite/find.gnu/.*exp Thanks for the ti

Re: [PATCH 1/4] Add a test which checks $CWD for find -execdir {} + and ... {} ;

2010-04-12 Thread James Youngman
On Mon, Apr 12, 2010 at 4:56 PM, Eric Blake wrote: > On 04/10/2010 02:33 PM, James Youngman wrote: >> * find/testsuite/find.gnu/execdir-multiple.exp: New test; verifies >> that for -execdir +, all the execs occur with the correct workikng > > s/workikng/working/ Done. > If you haven't pushed alr

Re: [PATCH 2/4] Exec predicates now store which directory they want to run in.

2010-04-12 Thread James Youngman
On Mon, Apr 12, 2010 at 5:06 PM, Eric Blake wrote: > On 04/10/2010 02:33 PM, James Youngman wrote: >> (starting_dir): Remove devlaration of global variable. >> (starting_desc): Remove devlaration of global variable. > > s/devlaration/declaration/g Thanks, fixed. > If you are already in an atexit

[bug #27983] Windows text mode mis-interpreted

2010-04-12 Thread Eric Blake
Follow-up Comment #11, bug #27983 (project findutils): I have no qualms with using 'b' - on a POSIX system it has no effect, but we know that on non-POSIX systems, it is standardized by C99 and has a beneficial effect. But I am adamantly opposed to using 't' - it is not specified by any standard

[bug #27983] Windows text mode mis-interpreted

2010-04-12 Thread Ilguiz Latypov
Follow-up Comment #10, bug #27983 (project findutils): > Cygwin cannot be POSIX-compliant I meant "Cygwin applications cannot rely on POSIX compliance of the system features they consume". ___ Reply to this item at:

[bug #27983] Windows text mode mis-interpreted

2010-04-12 Thread Ilguiz Latypov
Follow-up Comment #9, bug #27983 (project findutils): > app | d2u | xargs > That is a one-size-fits-all solution - it works no matter the windows app on the left and no matter the consumer on the right. This means that the developers should be aware about the newline subtlety that may be expose

Re: [bug #12162] Enhancement req: finding files less than 2Gb in size [needs community feedback]

2010-04-12 Thread Michael D. Vose
I think James Youngman's suggestion of using "length" is a bit better than "filesize". There is no syntactic overlap between "length" and "size".

Savannah bug #23065 -- -daystart measures from start of tomorrow

2010-04-12 Thread rre...@iol.it
Hi, I've tried to fix the bug referenced to at https://savannah.gnu.org/bugs/?23065. In my opinion, -daystart should have effect on -{a,c,m}time only. Of course, if my solution is correct, the man and info pages have to be updated as well. Roberto Reale rre...@iol.it diff -Naur findutils/fin

Re: [PATCH 2/3] Fix false positives for syntax check sc_prohibit_test_minus_ao.

2010-04-12 Thread Eric Blake
On 04/11/2010 04:35 AM, James Youngman wrote: > * .x-sc_prohibit_test_minus_ao: Add all the DejaGnu scripts to the > list of exceptions to the 'test C1 -a C2' syntax check, since they > are not actually shell scripts. > > Signed-off-by: James Youngman > --- > .x-sc_prohibit_test_minus_ao | 234

[bug #24561] find -ok should not redirect stdin

2010-04-12 Thread Eric Blake
Follow-up Comment #5, bug #24561 (project findutils): I haven't had as much time for findutils lately as I had hoped, so if you beat me to it, I won't mind. I'm still undecided on whether -okdir should behave the same as the (eventually) fixed -ok or keep its current semantics of redirecting std

Re: [PATCH 2/4] Exec predicates now store which directory they want to run in.

2010-04-12 Thread Eric Blake
On 04/10/2010 02:33 PM, James Youngman wrote: > (starting_dir): Remove devlaration of global variable. > (starting_desc): Remove devlaration of global variable. s/devlaration/declaration/g > + > +static bool > +record_exec_dir (struct exec_val *execp) > +{ > + if (!execp->wd_for_exec) > +{ >

Re: [PATCH 1/4] Add a test which checks $CWD for find -execdir {} + and ... {} ;

2010-04-12 Thread Eric Blake
On 04/10/2010 02:33 PM, James Youngman wrote: > * find/testsuite/find.gnu/execdir-multiple.exp: New test; verifies > that for -execdir +, all the execs occur with the correct workikng s/workikng/working/ > directory. > * find/testsuite/find.gnu/execdir-multiple.xo: Expected output for > this test

[bug #27983] Windows text mode mis-interpreted

2010-04-12 Thread Eric Blake
Follow-up Comment #8, bug #27983 (project findutils): If you really want xargs to handle data from a native windows application, then add d2u into the pipeline: app | d2u | xargs That is a one-size-fits-all solution - it works no matter the windows app on the left and no matter the consumer on

[bug #29512] [feature request] xargs parallel processing env-val improvement

2010-04-12 Thread anonymous
Follow-up Comment #10, bug #29512 (project findutils): now it's easy to map any values to slots, eg: seq 0 25 |./xargs -P3 -n3 --process-slot-var=XARGS_SLOT bash -c 'echo [$XARGS_SLOT] $(echo "ssh a;ssh b;ssh c" | cut -d ";" -f $[ $XARGS_SLOT + 1] ); sleep 0.5' x

[bug #29512] [feature request] xargs parallel processing env-val improvement

2010-04-12 Thread anonymous
Follow-up Comment #9, bug #29512 (project findutils): Cool, thanks :-) Will it be merged to the git? 0 ;) har...@harvie-ntb xargs $ seq 0 25 |./xargs -P3 -n3 --process-slot-var=XARGS_SLOT bash -c 'echo [$XARGS_SLOT] $@; sleep 0.5' x [0] 0 1 2 [1] 3 4 5 [2] 6 7 8 [0] 9 10 11 [1] 12 13 14 [2] 15