Re: assertion failures of findutils 4.5.7

2010-04-05 Thread Kamil Dudka
On Monday 05 of April 2010 22:01:22 James Youngman wrote: > I attach a set of patches. They're the same as the patches I emailed > yesterday, but rebased against current head. The patches look good! I've applied all of them and built as findutils-4.5.7-4.fc14. Thanks! Kamil

[PATCH] Use the getopt-gnu module, not the obsolete getopt module.

2010-04-05 Thread James Youngman
I've pushed the attached patch. 2010-04-06 James Youngman * import-gnulib.config (modules): Use the getopt-gnu module from gnulib rather than the (obsolete) getopt module. From 1284636a2e4e64cc57fe8241fa0ed290205843f6 Mon Sep 17 00:00:00 2001 From: James Youngman Date: Tue, 6

Re: Patch that adds a new test to find

2010-04-05 Thread Eric Blake
[it's customary to reply inline, rather than top-posting, on technical lists] On 04/05/2010 03:13 PM, rre...@iol.it wrote: > Thank you very much for your kind and accurate answer! I have tried to > modify my patch so as to solve the problems you pointed at. I know that > looking at the content o

Re: Patch that adds a new test to find

2010-04-05 Thread James Youngman
diff -Nur findutils/find/cmp.c findutils-rreale/find/cmp.c --- findutils/find/cmp.c1970-01-01 01:00:00.0 +0100 +++ findutils-rreale/find/cmp.c 2010-04-05 22:29:19.0 +0200 @@ -0,0 +1,224 @@ +/* Buffer primitives for comparison operations. Adapted from the + following files

Re: Patch that adds a new test to find

2010-04-05 Thread rre...@iol.it
Thank you very much for your kind and accurate answer! I have tried to modify my patch so as to solve the problems you pointed at. I know that looking at the content of a file is not in the spirit of find, but anyway I believe it is a very useful exercise for me to go and hack such an excellent p

Re: assertion failures of findutils 4.5.7

2010-04-05 Thread Kamil Dudka
On Monday 05 of April 2010 22:24:18 Kamil Dudka wrote: > On Monday 05 of April 2010 22:01:22 James Youngman wrote: > > This is a known problem, Savannah bug #27213. Yesterday, I mailed > > patches to the list which should fix this. See > > Mailed where actually? I somehow missed them and still

Re: assertion failures of findutils 4.5.7

2010-04-05 Thread Kamil Dudka
On Monday 05 of April 2010 22:01:22 James Youngman wrote: > This is a known problem, Savannah bug #27213. Yesterday, I mailed > patches to the list which should fix this. See Mailed where actually? I somehow missed them and still don't see any beyond this mail... The only patch I encountered

Re: assertion failures of findutils 4.5.7

2010-04-05 Thread James Youngman
On Mon, Apr 5, 2010 at 3:55 PM, Kamil Dudka wrote: > Hello, > > Sami Farin (CC'd) discovered some flaws in recent findutils and reported > them at Red Hat bugzilla: > > https://bugzilla.redhat.com/show_bug.cgi?id=579476#c0 > https://bugzilla.redhat.com/show_bug.cgi?id=579476#c2 > > Here are propos

[bug #27983] Windows text mode mis-interpreted

2010-04-05 Thread Eric Blake
Follow-up Comment #4, bug #27983 (project findutils): In your example, $tf1 is created in text mode, so it contains file names listed with carriage returns. Then you use cat, which preserves binary mode, through a pipe which also preserves binary mode. But this is an example of a useless use of

[bug #27983] Windows text mode mis-interpreted

2010-04-05 Thread Ilguiz Latypov
Follow-up Comment #3, bug #27983 (project findutils): Is the expectation in the test script valid? > mount -t "$(cygpath -w "${dir}")" /textmode [..] > tf1="/textmode/file1.txt" > tf2="/textmode/file2.txt" [..] > echo "foo" > "${tf1}" > echo "bar" >> "${tf1}" [..] > cat "${tf1}" | xargs -i echo

assertion failures of findutils 4.5.7

2010-04-05 Thread Kamil Dudka
Hello, Sami Farin (CC'd) discovered some flaws in recent findutils and reported them at Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=579476#c0 https://bugzilla.redhat.com/show_bug.cgi?id=579476#c2 Here are proposed patches: https://bugzilla.redhat.com/attachment.cgi?id=404487 ht

[bug #27983] Windows text mode mis-interpreted

2010-04-05 Thread Eric Blake
Update of bug #27983 (project findutils): Status:None => Wont Fix Assigned to:None => ericb ___ Follow-up Comment #2: Cygwin does prov

Re: [PATCH] frcode: avoid link failure due to multiple program_name definitions

2010-04-05 Thread James Youngman
Applied and pushed. Thanks! James.

[PATCH] frcode: avoid link failure due to multiple program_name definitions

2010-04-05 Thread Jim Meyering
Hello, I tried to build from git and got this: frcode.c: In function 'main': frcode.c:226: warning: implicit declaration of function 'set_program_name' mv -f .deps/frcode.Tpo .deps/frcode.Po gcc -std=gnu99 -Wdeclaration-after-statement -Wall -Wall -Wshadow -Wformat-security -Winit-self -

Re: Patch that adds a new test to find

2010-04-05 Thread James Youngman
On Sun, Apr 4, 2010 at 7:38 PM, rre...@iol.it wrote: > Hi, > > I have written a small patch (against findutils 4.4.2) that > adds a switch to find (namely, -samecontent) in order to find > duplicates of a file.  In other words, the command > >  find -samecontent FILENAME > > is now roughly equival