Re: [PATCH 09/19] Remove some obsolete source files from POTFILES.in

[adding bug-gnulib] On 04/02/2010 04:47 PM, James Youngman wrote: > --- > po/POTFILES.in | 15 --- > 1 files changed, 0 insertions(+), 15 deletions(-) > > diff --git a/po/POTFILES.in b/po/POTFILES.in > index 3ab3107..ef3485a 100644 > --- a/po/POTFILES.in > +++ b/po/POTFILES.in > @@

Re: [PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE.

On 04/02/2010 04:47 PM, James Youngman wrote: > > + Move safe_atoi out into a separate module. > + * find/parser.c: Include "safe-atoi.h". Remove the body of safe_atoi. > + (parse_group): pass options.err_quoting_style to safe_atoi. > + (insert_depthspec): Likewise. > + (pars

Re: [PATCH 06/19] Avoid false positives for the sc_prohibit_test_minus_ao syntax check.

On 04/02/2010 04:47 PM, James Youngman wrote: > -find subdir -newer timestamp -a \ > - -exec test @{...@} -nt timestamp \; -a \ > +find subdir -newer timestamp -and \ > + -exec test @{...@} -nt timestamp \; -and \ Good - in this case, the -a was an argument of find(1), not test(1), and fin

Re: [PATCH 03/19] Fix some space-followed-by-tab sequences.

On 04/02/2010 04:47 PM, James Youngman wrote: > * NEWS: Change space-tab sequences to just spaces. > * build-aux/check-testfiles.sh (main): Likewise > * build-aux/src-sniff.py (checkers): Likewise. > * find/Makefile.am: Likewise. > * find/testsuite/find.posix/sv-bug-25359.exp: Likewise. > * import-

[PATCH 19/19] Check for accidental modifications to the wrong section of the NEWS file.

* cfg.mk (local-checks-to-skip): Remove sc_immutable_news. (old_NEWS_hash): add existing hash (from "make update-NEWS-hash"). Signed-off-by: James Youngman --- ChangeLog |5 + cfg.mk|8 +++- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog

[PATCH 18/19] cfg.mk: simplify variables

* cfg.mk: Append the names of checks to skip to local-checks-to-skip rather than inventing 7 new variables. Signed-off-by: James Youngman --- ChangeLog |4 cfg.mk| 20 +--- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index

[PATCH 17/19] Don't include quote.h/quotearg.h where it is not used.

* find/find.c: Don't include "quote.h", it's not used. * find/ftsfind.c: Likewise. * find/parser.c: Likewise. * locate/locate.c: Likewise. * locate/word_io.c: Likewise. * cfg.mk (skip_dunno): Enable check sc_prohibit_quote_without_use. * find/find.c: Don't include "quotearg.h", it's not used. * lib

[PATCH 16/19] Use set_program_name() to remember the programs' names.

* cfg.mk *skip(defer): Enable sc_program_name. Remove the now-unused variable skip_defer. * find/ftsfind.c: Include "program_name.h". (main): Call set_program_name. * find/find.c: Include "program_name.h". (main): Call set_program_name. * locate/locate.c: Include "program_name.h". (dolocate): Call

[PATCH 15/19] Avoid using magic numbers as exit statuses.

Avoid using magic numbers as exit statuses. * cfg.mk (skip_defer): Enable sc_prohibit_magic_number_exit. * doc/find-maint.texi (Security): Avoid error (1, ...) in the example patch. * find/find.c (main): Use exit status EXIT_FAILURE instead of 1. (wd_sanity_check): Likewise. (safely_chdir_lstat): L

[PATCH 14/19] Avoid sc_prohibit_stat_st_blocks check, since it is broken.

* cfg.mk (skip_broken_checks): Skip sc_prohibit_stat_st_blocks. Signed-off-by: James Youngman --- ChangeLog |5 + cfg.mk|6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 48b7e14..58329a9 100644 --- a/ChangeLog +++ b/ChangeLog @@

[PATCH 12/19] sc_prohibit_strcmp gives false positives when neither argument is a constant, so skip that check

--- cfg.mk |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 9b6f8ad..b43b3e5 100644 --- a/cfg.mk +++ b/cfg.mk @@ -24,8 +24,7 @@ skip_dunno = sc_immutable_NEWS sc_makefile_at_at_check \ # Understand, but fix later. skip_defer = sc_program_na

[PATCH 13/19] Enable syntax checker sc_the_the, detecting doubled 'the'.

* cfg.mk (false_positives): Enable syntax checker sc_the_the * build-aux/src-sniff.py (checkers): Avoid false positive with sc_the_the. Signed-off-by: James Youngman --- ChangeLog |5 + build-aux/src-sniff.py |2 +- cfg.mk |2 +- 3 files changed, 7 in

[PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE.

Signed-off-by: James Youngman --- ChangeLog| 12 configure.ac | 16 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9abbc98..4163d15 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,16 @@ 2010-04-02 James Youngma

[PATCH 10/19] Remove files which exist but have no translated messages.

* po/POTFILES.in: Remove dircallback.c, listfile.c. * lib/listfile.c: Don't include libintl, since there are no translated messages in this file. * lib/dircallback.c: Likewise. Signed-off-by: James Youngman --- ChangeLog |7 +++ lib/dircallback.c | 17 - lib/lis

[PATCH 11/19] Avoid sscanf. Avoid false positives for sc_prohibit_atoi_atof.

* lib/fdleak.c (get_proc_max_fd): Use safe_atoi to do string to int conversion, instead of sscanf. Skip '.' and '..'. * find/util.c (set_option_defaults): Avoid false positive with sc_prohibit_atoi_atof. (check_nofollow): Likewise. * cfg.mk (skip_defer): Enable the sc_prohibit_atoi_atof check. Si

[PATCH 09/19] Remove some obsolete source files from POTFILES.in

--- po/POTFILES.in | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index 3ab3107..ef3485a 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -5,21 +5,6 @@ # modification, are permitted provided the copyright notice # and th

[PATCH 08/19] Move safe_atoi out into a separate module.

* find/parser.c: Include "safe-atoi.h". Remove the body of safe_atoi. (parse_group): pass options.err_quoting_style to safe_atoi. (insert_depthspec): Likewise. (parse_user): Likewise. * lib/safe-atoi.h: New file. * lib/safe-atoi.c: New file. Add parameter for quoting style (to avoid an external r

[PATCH 04/19] Fix some compilation unused-result and missing-declaration warnings.

Eliminate some unused function result warnings. * lib/unused-result.h: New file, defines function attribute macro __attribute_warn_unused_result__. * lib/Makefile.am (EXTRA_DIST): Add unused-result.h. * find/ftsfind.c (find): Issue a diagnostic if fts_close fails, change return type to bool and ret

[PATCH 06/19] Avoid false positives for the sc_prohibit_test_minus_ao syntax check.

* doc/find.texi (Updating A Timestamp File): Work around a syntax check designed to prevent the use of "test X -a Y". * find/find.1: Likewise. Signed-off-by: James Youngman --- ChangeLog |5 + cfg.mk|2 +- doc/find.texi |6 +++--- find/find.1 |2 +- 4 files chan

[PATCH 05/19] Don't include xalloc.h where we don't use it.

* find/ftsfind.c: We don't use anything from xalloc.h, so don't #include it. Signed-off-by: James Youngman --- ChangeLog |3 +++ cfg.mk |3 +-- find/ftsfind.c |1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9c656f4..93ec28

[PATCH 03/19] Fix some space-followed-by-tab sequences.

* NEWS: Change space-tab sequences to just spaces. * build-aux/check-testfiles.sh (main): Likewise * build-aux/src-sniff.py (checkers): Likewise. * find/Makefile.am: Likewise. * find/testsuite/find.posix/sv-bug-25359.exp: Likewise. * import-gnulib.sh (check_merge_driver): Likewise. * m4/withfts.m4

[PATCH 02/19] * cfg.mk: Explain that we cannot enable the sc_texinfo_acronym syntax check right now, since the perm.texi file uses @acronym{GNU} but we try to keep that in sync. with coreutils.

Signed-off-by: James Youngman --- ChangeLog |4 cfg.mk| 11 --- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1dcf0e9..42d2a51 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2010-04-02 James Youngman + * cfg.

[PATCH 01/19] Mark some missed error messages for translation.

* find/parser.c (safe_atoi): Likewise. * find/pred.c (pred_context): Likewise. (do_fprintf): Likewise. * xargs/xargs.c (xargs_do_exec): Translate error message. (xargs_do_exec): Likewise. * lib/buildcmd.c (exceeds): Likewise. Signed-off-by: James Youngman --- ChangeLog |8 cfg.