Re: [Patch] faster fnmatch

2009-05-01 Thread Bruno Haible
Hello Ondrej, Nice work already! > *abc* > en_US.UTF-8 > user: 2.71 > user: 0.23 > ... > *ab[a-z]* > en_US.UTF-8 > user: 2.85 > user: 3.32 > C > user: 0.86 > user: 1.25 Hmm, well, users are expecting a speedup through your module always. If it some (not too rare) cases the glibc fnmatch is

Re: [Patch] faster fnmatch

2009-05-01 Thread Ralf Wildenhues
Hello Ondrej, * Ondrej Bilka wrote on Thu, Apr 30, 2009 at 10:41:49PM CEST: > I here attach compiled fnmatch I wrote as gnulib module. I haven't read your patch closely, but it fails to check the return value from all of the malloc/realloc... functions, opening up several opportunities for segme