Re: [PATCH] Enable -Wall compiler warnings and fix them.

2009-03-09 Thread James Youngman
On Sun, Mar 8, 2009 at 12:53 AM, James Youngman wrote: > * configure.ac: Turn on -Wall warnings. > * find/find.c (process_dir): Print unsigned values of unspecified > width as uintmax_t. > * xargs/xargs.c: Include and , but without > the include guards (since we assume an ISO C platform anyway).

Re: [PATCH] Switch to using a merge driver for the ChangeLog file.

2009-03-09 Thread James Youngman
On Mon, Mar 9, 2009 at 1:46 PM, James Youngman wrote: > On Mon, Mar 9, 2009 at 2:34 AM, Eric Blake wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> According to James Youngman on 3/8/2009 7:43 AM: >>> * .gitattributes: new file >> >> You went with the name merge.cl-merge.driver, w

Re: [bug #24342] -inum predicate shoud use dirent.d_ino instead of stat.st_ino

2009-03-09 Thread James Youngman
[ I dropped bug-gnulib from CC: ] On Sun, Mar 8, 2009 at 8:05 PM, George Spelvin wrote: > Notice how it seems to assume that state.have_stat describes the same > "current file" as the stat_buf argument. > > So perhaps the leaf flag could be stuffed into the state structure. Yes and yes. > (Id

Re: [PATCH] Switch to using a merge driver for the ChangeLog file.

2009-03-09 Thread James Youngman
On Mon, Mar 9, 2009 at 2:34 AM, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to James Youngman on 3/8/2009 7:43 AM: >> * .gitattributes: new file > > You went with the name merge.cl-merge.driver, while gnulib, coreutils, > autoconf, libtool, and m4 all used mer