[bug #25359] files/testsuite/find.gnu/posix-h.exp tests fail v4.5.3

2009-02-21 Thread James Youngman
Follow-up Comment #1, bug #25359 (project findutils): Does the system under test have a stat()able /etc/passwd file? Can you reproduce the problem manually? (This test passes for me here, obviously, or 4.5.3 would never have been released). Does the problem apply only to ftsfind, or is oldfin

Re: RFC: "-contains" option

2009-02-21 Thread Eddie Kohler
James Youngman wrote: On Sat, Feb 21, 2009 at 10:23 PM, Eddie Kohler wrote: exclude=$(find . -name .find-ignore -printf '%h\n' | sort -u); find . \! \( -false $(for e in $exclude ; do printf ' -o -name "%s" ' $e; done) \) , -true > /dev/null => 3.06s There is a -prune missing from both find

Re: [bug #19374] Insufficient quoting of PRUNEPATHS in updatedb

2009-02-21 Thread James Youngman
On Mon, Feb 9, 2009 at 9:22 AM, anonymous wrote: > > Follow-up Comment #2, bug #19374 (project findutils): > > Here is a patch: > > --- updatedb.org2009-01-27 13:29:28.575086300 +0100 > +++ updatedb2009-02-09 10:19:41.132505500 +0100 > @@ -163,7 +163,7 @@ > # Trailing slashes result i

Re: RFC: "-contains" option

2009-02-21 Thread James Youngman
On Sat, Feb 21, 2009 at 10:23 PM, Eddie Kohler wrote: > exclude=$(find . -name .find-ignore -printf '%h\n' | sort -u); find . \! \( > -false $(for e in $exclude ; do printf ' -o -name "%s" ' $e; done) \) , > -true > /dev/null > => 3.06s There is a -prune missing from both find expressions there

Re: RFC: "-contains" option

2009-02-21 Thread Eddie Kohler
James Youngman wrote: exclude=$(find . -name .find-ignore -printf '%h\n' | sort -u) find . \! \( -false $( for e in $exclude ; do printf ' -o -name "%s" ' $e; done) \) It's about twice as slow as -contains -- as you might expect, since it traverses the directory structure twice. find . -type d

Re: RFC: "-contains" option

2009-02-21 Thread James Youngman
On Sat, Feb 21, 2009 at 6:20 PM, Eddie Kohler wrote: > Hi, > > I frequently use "find" to search collections of files while pruning certain > directories. However, I'd often like to prune build directories and the > like, > and these don't have consistent names. > > One solution is to prune direc

RFC: "-contains" option

2009-02-21 Thread Eddie Kohler
Hi, I frequently use "find" to search collections of files while pruning certain directories. However, I'd often like to prune build directories and the like, and these don't have consistent names. One solution is to prune directories that contain a file named ".find-ignore". This can be coded

Re: make find *much* faster on reiserfs

2009-02-21 Thread James Youngman
On Sun, Feb 15, 2009 at 11:44 PM, Jim Meyering wrote: > [reposting to the right list] > > Following up on this post, > > http://thread.gmane.org/gmane.comp.gnu.findutils.bugs/3894 > > now that the gnulib/fts changes are in, > here are the parts required (in addition to getting the > latest fts.c)

Updated the version of gnulib used by findutils

2009-02-21 Thread James Youngman
I've updated findutils to a newer version of gnulib (the patch is attached). There should be a performance increase for ftsfind here, but Jim Meyering has a further patch to findutils to improve performance on filesystems which do not populate the d_type member of struct dirent. I will update the

Re: 3 patches: avoid warnings, unnecessary include

2009-02-21 Thread James Youngman
On Sun, Feb 15, 2009 at 3:49 PM, Jim Meyering wrote: > Hi, > > Here are three tiny patches. > > From 4af19b0784919915be4341b9917192c0d7dd232e Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Sun, 11 Jan 2009 19:32:29 +0100 > Subject: [PATCH 1/3] find: avoid warning about unused local > > * f