Re: [PATCH 3/3] find: take advantage of new gnulib/fts leaf-optimization

2009-01-03 Thread James Youngman
On Sun, Jan 4, 2009 at 12:09 AM, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to James Youngman on 1/3/2009 3:04 PM: >> 2. There exist other filesystems where (st_links - (0 or 2)) < >> (subdirectory count). The only example I can think of offhand is >> AFS.

Re: [PATCH 3/3] find: take advantage of new gnulib/fts leaf-optimization

2009-01-03 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to James Youngman on 1/3/2009 3:04 PM: > 2. There exist other filesystems where (st_links - (0 or 2)) < > (subdirectory count). The only example I can think of offhand is > AFS. There is some incomplete information at > http://bugs.debian

Re: [PATCH 3/3] find: take advantage of new gnulib/fts leaf-optimization

2009-01-03 Thread James Youngman
On Sat, Dec 27, 2008 at 11:42 AM, Jim Meyering wrote: > If find were to apply this same technique, it would make the > -noleaf predicate a no-op. > > FYI, when I run the modified find on a reiserfs-backed 1.6M-file maildir > hierarchy, it takes only 80 seconds (2.6.26, athlon64 3400+, 2yr-old dis

Re: [PATCH 1/3] fix a typo in a comment

2009-01-03 Thread James Youngman
On Fri, Dec 26, 2008 at 5:29 PM, Jim Meyering wrote: > > * find/ftsfind.c (consider_visiting): s/fill/full/ Applied, thanks.

Re: [PATCH] avoid build failure when compiling with -DGNULIB_PORTCHECK

2009-01-03 Thread James Youngman
On Fri, Dec 26, 2008 at 5:20 PM, Jim Meyering wrote: > + > + /* Avoid failure when compiling with -DGNULIB_PORTCHECK. */ > +#undef ctime To be honest, I am not comfortable with this fix, mostly because I would prefer to avoid interfering with a global symbol; if a later porting change needed