Re: [PATCH] Error message clarification

2007-03-31 Thread James Youngman
On 3/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Mine was just a quick hack to alleviate the matter, but yours surely offers more than that. Applied. By the way, I think you introduced some broken things into current find/ CVS: Where is get_stat_birthtime() defined? It is from gnul

Re: [PATCH] Error message clarification

2007-03-31 Thread leslie . polzer
On Sat, Mar 31, 2007 at 07:14:24PM +0100, James Youngman wrote: > How about this patch, which gives a more specific error? > [...] Well, even better! :) Mine was just a quick hack to alleviate the matter, but yours surely offers more than that. By the way, I think you introduced some broken thin

Re: [PATCH] Error message clarification

2007-03-31 Thread James Youngman
On 3/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: When a predicate is not syntactically correct, the find parser will currently say: "invalid predicate `%s'" which IMO obscures the fact that the predicate NAME may be alright, but the number or format of parameters didn't match. How a

Re: Allocating memory in parser.c

2007-03-31 Thread James Youngman
On 3/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: This is not of concern to the xattr support, but the question popped up nevertheless: Is there a place to free memory that has been allocated in a parse_* function? There isn't. This is mainly because in the current implementation of f

[PATCH] Error message clarification

2007-03-31 Thread leslie . polzer
Another quickie. When a predicate is not syntactically correct, the find parser will currently say: "invalid predicate `%s'" which IMO obscures the fact that the predicate NAME may be alright, but the number or format of parameters didn't match. Therefore: "invalid or malformed predicat

Allocating memory in parser.c

2007-03-31 Thread leslie . polzer
This is not of concern to the xattr support, but the question popped up nevertheless: Is there a place to free memory that has been allocated in a parse_* function? Leslie -- NEW homepage: https://viridian.dnsalias.net/~sky/homepage/ gpg --keyserver pgp.mit.edu --recv-keys DD4EBF83 pgpOEaU

[PATCH] Draft for xattr support

2007-03-31 Thread leslie . polzer
Hello James, the attached patch includes the guts for extended attributes support in find. Not yet included: * wildcard matching attributes with fnmatch() * success rate estimation * checks in configure.ac for attr headers and libraries * documentation changes Open questi