gas new (2.20) rebuffer_line() excessive read() syscalls

2013-03-19 Thread Jim Tison
Hi, I can't get a web browser connection to sourceware.org, so I can't open a PR on this (I will as soon as I can unless you advise me not to) but I wanted to warn you guys this is coming. I've got a C language source code TU that is 1.3 MiB large. I didn't write it (I know better), but I ha

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread petechou at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #11 from pete 2013-03-20 02:04:21 UTC --- Hello Ian, Would you please comment on the issue and patch? - Thanks, Pete (In reply to comment #10) > I have no object to what is proposed but the decision is Ian's. > > On Tue, Mar 12

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread ian at airs dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #12 from Ian Lance Taylor 2013-03-20 03:29:49 UTC --- oldsym->in_dyn() will return true if the symbol was seen in a dynamic object. I don't see why we should create the symbol if it is seen in a dynamic object. It seems that the

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread ian at airs dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #13 from Ian Lance Taylor 2013-03-20 03:32:47 UTC --- oldsym->in_dyn() will return true if the symbol was seen in a dynamic object. I don't see why we should create the symbol if it is seen in a dynamic object. It seems that the

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread dougkwan at google dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #14 from Doug Kwan 2013-03-20 04:41:03 UTC --- The special symbols in question __exidx_{start,end} were exported from DSO's by mistake in both ld & gold and the mistake has been fixed in both linkers. We really don't want referenc

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread ian at airs dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #15 from Ian Lance Taylor 2013-03-20 04:44:36 UTC --- I think that is what my patch does. Did I get it wrong? I think it probably makes sense in general to create an only_if_ref linker-defined symbol if there is a ref in the regu

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread petechou at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #16 from pete 2013-03-20 05:38:56 UTC --- (In reply to comment #15) > I think that is what my patch does. Did I get it wrong? I'm thinking the patch does the same thing as mine. I have 2 questions: 1. in_reg() and in_dyn() seem

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread petechou at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #17 from pete 2013-03-20 05:54:20 UTC --- (In reply to comment #16) > (In reply to comment #15) > > I think that is what my patch does. Did I get it wrong? And we should return NULL if oldsym->in_reg() is true instead? if (o

[Bug gold/15200] Runtime undefined reference to __exidx_start/_end

2013-03-19 Thread petechou at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=15200 --- Comment #18 from pete 2013-03-20 06:20:57 UTC --- Sorry! Yours is correct. Forget about this. (In reply to comment #17) > > And we should return NULL if oldsym->in_reg() is true instead? > > if (oldsym == NULL) > return NULL;