[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-08 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #34 from Kaylee --- I'm getting several failures: > FAIL: Build pr22393-2 (-z nosectionheader, none) > FAIL: Build pr22393-2 (PIE, -z nosectionheader, none) > FAIL: Build pr22393-2 (-z nosectionheader, objcopy) > FAIL: Build pr223

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-08 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #39 from Kaylee --- Created attachment 12359 --> https://sourceware.org/bugzilla/attachment.cgi?id=12359&action=edit testcase for GNU_PROPERTY_NO_COPY_ON_PROTECTED segfault The attached file exports an `int foo`, linking against

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-08 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #35 from Kaylee --- There are a couple of typos in the comments: "symbol stable", "string stable", and "memory chekers". -- You are receiving this mail because: You are on the CC list for the bug.

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-08 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #38 from Kaylee --- > How can I reproduce it? Do they fail on master branch? Yeah, they fail on master for me. Additionally, I've just found out that ld segfaults when trying to link against a shared object with GNU_PROPERTY_NO_C

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-07 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #31 from Kaylee --- Yep, I'm not getting the warning with the new version. Also the test case that I mentioned failed appears to be ld/testsuite/ld-x86-64/pr17618.d, which I think is probably unrelated. -- You are receiving this

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #28 from Kaylee --- Created attachment 12358 --> https://sourceware.org/bugzilla/attachment.cgi?id=12358&action=edit test case for note warning This is a testcase for the warning about no note section. I think any shared library

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #27 from Kaylee --- Created attachment 12357 --> https://sourceware.org/bugzilla/attachment.cgi?id=12357&action=edit testcase for objcopy breakage This .so works fine, but if put through objcopy (even without flags), objcopy wil

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #24 from Kaylee --- Apologies, with the new objcopy version it isn't generating overlapping PT_LOAD entries, though it is still modifying them and moving the program header. -- You are receiving this mail because: You are on the

[Bug ld/25617] ld should reconstruct dynamic symbol table from PT_DYNAMIC when there is no section header

2020-03-06 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #23 from Kaylee --- I got a failure in the ld testsuite in x86-64.exp. Unfortunately, about an hour later, my computer crashed, and I have since been unable to reproduce it. I think the text was something like "RELATIVE RELOCATION

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-05 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #20 from Kaylee --- Works for me now! -- You are receiving this mail because: You are on the CC list for the bug.

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-05 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #18 from Kaylee --- I get uninitialised variable usage errors when I try to build it, in this section of elf_link_is_defined_archive_symbol(): > if (elf_bad_symtab (abfd)) > { > extsymcount = symcount; > extsymof

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-04 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #16 from Kaylee --- Created attachment 12348 --> https://sourceware.org/bugzilla/attachment.cgi?id=12348&action=edit patch to add test for -z nosectionheader This patch adds the test for it, based against your branch. -- You a

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-04 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #14 from Kaylee --- The information on the number of symbols in the symbol table is available in DT_HASH->nchain, as the chain table parallels the symbol table. -- You are receiving this mail because: You are on the CC list for t

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-04 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #10 from Kaylee --- Created attachment 12343 --> https://sourceware.org/bugzilla/attachment.cgi?id=12343&action=edit patch to add flag to not emit the section header table to the BFD-based ld I'll add a testcase shortly. -- Yo

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-04 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #9 from Kaylee --- Created attachment 12342 --> https://sourceware.org/bugzilla/attachment.cgi?id=12342&action=edit patch to add BFD support for not emitting the section header table -- You are receiving this mail because: You

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-03 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 Kaylee changed: What|Removed |Added Attachment #12336|0 |1 is obsolete|

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-03 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #8 from Kaylee --- Created attachment 12341 --> https://sourceware.org/bugzilla/attachment.cgi?id=12341&action=edit patch to add a test for the flag This adds some testing for the flag. -- You are receiving this mail because:

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-03 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #5 from Kaylee --- Created attachment 12336 --> https://sourceware.org/bugzilla/attachment.cgi?id=12336&action=edit patch to add flag to not emit section header tables I've written a small patch to add such a flag, does this loo

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-01 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #3 from Kaylee --- Created attachment 12332 --> https://sourceware.org/bugzilla/attachment.cgi?id=12332&action=edit testcase with only shstrtab This testcase has a minimal section header table containing only `.shstrtab`. This w

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-01 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617 --- Comment #2 from Kaylee --- Created attachment 12331 --> https://sourceware.org/bugzilla/attachment.cgi?id=12331&action=edit testcase with no section headers This test case has no section headers; gold immediately errors due to attemptin

[Bug gold/25617] New: Gold looks up shared object information in section headers instead of the dynamic array

2020-02-29 Thread klkblake at gmail dot com
: UNCONFIRMED Severity: normal Priority: P2 Component: gold Assignee: ccoutant at gmail dot com Reporter: klkblake at gmail dot com CC: ian at airs dot com Target Milestone: --- For shared objects, all information needed for linking is in the