Re: [RFA] peXXigen.c, _bfd_XXi_swap_aux_in, wrong size used in memcpy.

2011-03-03 Thread Pedro Alves
ds doing here? > > > Maybe this? No. Think about what it would mean if the source is larger than the destination, or the opposite. I think doing what coffswap.h does is more appropriate: #if FILNMLEN != E_FILNMLEN #error we need to cope with truncating or extending FILNMLEN #else If coverity doesn't handle this, well, report them a bug. (I think binutils patches to go binut...@sourceware.org, not bug-binutils@gnu.org) -- Pedro Alves ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils

Re: [RFA] peXXigen.c, _bfd_XXi_swap_aux_in, wrong size used in memcpy.

2011-03-03 Thread Pedro Alves
t->x_file.x_fname, in->x_file.x_fname, FILNMLEN); > + memcpy (ext->x_file.x_fname, in->x_file.x_fname, E_FILNMLEN); If FILNMLEN can really be different from E_FILNMLEN, I'd've expected something else needs doing here? -- Pedro Alves ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils