Alan Modra wrote:
On Thu, Mar 03, 2011 at 12:27:02PM -0800, Michael Snyder wrote:
* elf64-x86-64.c (elf_x86_64_relocate_section): Remove dead code.
OK.
Committed, thanks.
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gn
Alan Modra wrote:
On Thu, Mar 03, 2011 at 11:12:34AM -0800, Michael Snyder wrote:
* coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
OK.
committed, thanks.
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.or
Alan Modra wrote:
On Thu, Mar 03, 2011 at 10:32:18AM -0800, Michael Snyder wrote:
* aoutx.h (aout_link_write_other_symbol): Missing break statement.
OK.
Committed, thanks.
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.g
Alan Modra wrote:
On Thu, Mar 03, 2011 at 10:25:31AM -0800, Michael Snyder wrote:
2011-03-03 Michael Snyder
* aoutx.txt (aout_final_link): Use sizeof int not sizeof int*.
aoutx.h. OK.
Committed, thanks.
___
bug-binutils mailing list
Alan Modra wrote:
On Thu, Mar 03, 2011 at 11:01:11AM -0800, Michael Snyder wrote:
2011-03-03 Michael Snyder
* archive.c (_bfd_slurp_extended_name_table): Fail if bfd_seek fails.
OK.
Thanks, committed.
___
bug-binutils mailing list
bug
Alan Modra wrote:
On Thu, Mar 03, 2011 at 12:12:52PM -0800, Michael Snyder wrote:
2011-03-03 Michael Snyder
* dwarf2.c (scan_unit_for_symbols): Stop memory leak.
OK.
Thanks for the review.
Committed.
___
bug-binutils mailing list
bug
Alan Modra wrote:
On Thu, Mar 03, 2011 at 10:46:09AM -0800, Michael Snyder wrote:
* archive.c (bsd_write_armap): Fail if stat fails.
I think it would be better to just set the timestamp to zero if stat
fails. There is precedent for this, eg. opncls.c:_maybe_make_executable.
Err, ca
On Thursday 03 March 2011 20:06:12, Michael Snyder wrote:
> >
> > Doesn't pe.h define them both the same?
>
> Hmm, yes... Coverity was evidently looking at the definition of
> E_FILNMLEN from include/coff/external.h, which is overridden by
> the one in pe.h.
Static analyser's output is always f
2011/3/3 Michael Snyder :
> If rel-r_type is equal to ARRA_SIZE, it will overflow the array.
>
> What say you?
>
>
> 2011-03-03 Michael Snyder
>
> * coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
I can't approve this patch, but looks ok.
Kai
___
On Thursday 03 March 2011 18:09:04, Michael Snyder wrote:
> 2011-03-03 Michael Snyder
>
> * peXXigen.c (_bfd_XXi_swap_aux_in): Use E_FILNMNEN instead of
> FILENMLEN, otherwise will overwrite array.
Doesn't pe.h define them both the same?
>
> Index: peXXigen.c
>
On Thu, Mar 03, 2011 at 12:06:12PM -0800, Michael Snyder wrote:
> * peXXigen.c (_bfd_XXi_swap_aux_in): Use sizeof in memcpy.
> (_bfd_XXi_swap_aux_out): Ditto.
OK. The less code I have to look at to verify something is correct,
the more I like it.
--
Alan Modra
Australia Development
On Thu, Mar 03, 2011 at 12:27:02PM -0800, Michael Snyder wrote:
> * elf64-x86-64.c (elf_x86_64_relocate_section): Remove dead code.
OK.
--
Alan Modra
Australia Development Lab, IBM
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.
On Thu, Mar 03, 2011 at 11:12:34AM -0800, Michael Snyder wrote:
> * coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
OK.
--
Alan Modra
Australia Development Lab, IBM
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.
On Thu, Mar 03, 2011 at 10:46:09AM -0800, Michael Snyder wrote:
> * archive.c (bsd_write_armap): Fail if stat fails.
I think it would be better to just set the timestamp to zero if stat
fails. There is precedent for this, eg. opncls.c:_maybe_make_executable.
--
Alan Modra
Australia Develo
On Thu, Mar 03, 2011 at 10:32:18AM -0800, Michael Snyder wrote:
> * aoutx.h (aout_link_write_other_symbol): Missing break statement.
OK.
--
Alan Modra
Australia Development Lab, IBM
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists
On Thu, Mar 03, 2011 at 10:25:31AM -0800, Michael Snyder wrote:
> 2011-03-03 Michael Snyder
>
> * aoutx.txt (aout_final_link): Use sizeof int not sizeof int*.
aoutx.h. OK.
--
Alan Modra
Australia Development Lab, IBM
___
bug-binutils mailin
On Thu, Mar 03, 2011 at 12:12:52PM -0800, Michael Snyder wrote:
> 2011-03-03 Michael Snyder
>
> * dwarf2.c (scan_unit_for_symbols): Stop memory leak.
OK.
--
Alan Modra
Australia Development Lab, IBM
___
bug-binutils mailing list
bug-binutils
On Thu, Mar 03, 2011 at 11:01:11AM -0800, Michael Snyder wrote:
> 2011-03-03 Michael Snyder
>
> * archive.c (_bfd_slurp_extended_name_table): Fail if bfd_seek fails.
OK.
--
Alan Modra
Australia Development Lab, IBM
___
bug-binutils mailing l
Within this case statement, the conditional cannot be true.
OK?
2011-03-03 Michael Snyder
* elf64-x86-64.c (elf_x86_64_relocate_section): Remove dead code.
Index: elf64-x86-64.c
===
RCS file: /cvs/src/src/bfd/elf64-x86-
ok?
2011-03-03 Michael Snyder
* dwarf2.c (scan_unit_for_symbols): Stop memory leak.
Index: dwarf2.c
===
RCS file: /cvs/src/src/bfd/dwarf2.c,v
retrieving revision 1.138
diff -u -p -u -p -r1.138 dwarf2.c
--- dwarf2.c29
Pedro Alves wrote:
On Thursday 03 March 2011 18:09:04, Michael Snyder wrote:
2011-03-03 Michael Snyder
* peXXigen.c (_bfd_XXi_swap_aux_in): Use E_FILNMNEN instead of
FILENMLEN, otherwise will overwrite array.
Doesn't pe.h define them both the same?
Hmm, yes... Coverity
If rel-r_type is equal to ARRA_SIZE, it will overflow the array.
What say you?
2011-03-03 Michael Snyder
* coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
Index: coff-x86_64.c
===
RCS file: /cvs/src/src/bfd/
OK?
2011-03-03 Michael Snyder
* archive.c (_bfd_slurp_extended_name_table): Fail if bfd_seek fails.
Index: archive.c
===
RCS file: /cvs/src/src/bfd/archive.c,v
retrieving revision 1.72
diff -u -p -u -p -r1.72 archive.c
-
Perhaps nit-picky -- what do you think?
2011-03-03 Michael Snyder
* archive.c (bsd_write_armap): Fail if stat fails.
Index: archive.c
===
RCS file: /cvs/src/src/bfd/archive.c,v
retrieving revision 1.72
diff -u -p -u -p -
Hey Nick,
Should there be a break here? Or a "FALLTHROUGH" comment?
Looks like a break to me...
Cheers,
Michael
2011-03-03 Michael Snyder
* aoutx.h (aout_link_write_other_symbol): Missing break statement.
Index: aoutx.h
=
Nick,
Seems to me it should be sizeof int, not int*.
What do you think?
Michael
2011-03-03 Michael Snyder
* aoutx.txt (aout_final_link): Use sizeof int not sizeof int*.
Index: aoutx.h
===
RCS file: /cvs/src/src/bfd/aou
OK Nick?
2011-03-03 Michael Snyder
* peXXigen.c (_bfd_XXi_swap_aux_in): Use E_FILNMNEN instead of
FILENMLEN, otherwise will overwrite array.
Index: peXXigen.c
===
RCS file: /cvs/src/src/bfd/peXXigen.c,v
retrievin
http://sourceware.org/bugzilla/show_bug.cgi?id=12525
--- Comment #7 from Ian Lance Taylor 2011-03-03 16:39:12
UTC ---
The intention of the code is that the file is guaranteed to be large enough by
the call to posix_fallocate in Output_file::map_no_anonymous. Does Solaris
have posix_fallocate?
http://sourceware.org/bugzilla/show_bug.cgi?id=12525
--- Comment #6 from Rainer Orth 2011-03-03
15:19:05 UTC ---
> --- Comment #4 from Ian Lance Taylor 2011-03-02
> 06:03:01 UTC ---
> It is possible that gdb is misleading in saying .
> I
> don't know. The address should be allocated via the
http://sourceware.org/bugzilla/show_bug.cgi?id=12525
--- Comment #5 from Rainer Orth 2011-03-03
14:54:39 UTC ---
> --- Comment #3 from Ian Lance Taylor 2011-03-02
> 05:59:33 UTC ---
> Yes, gold should recognize -dy. That's a bug.
Should I file a separate PR for that?
Rainer
--
Configu
30 matches
Mail list logo
