[PATCH 1/5] eaccess: constify path arguments

2016-08-11 Thread Mike Frysinger
Noticed when looking into segfault. The "discarding const qualifier" warning always makes me worried as it tends to come from bad code. --- externs.h| 2 +- lib/glob/glob.c | 2 +- lib/sh/eaccess.c | 10 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/externs.

Re: segfault w/bash-4.4-beta2 and assigning empty $*

2016-08-11 Thread Mike Frysinger
On 11 Aug 2016 08:32, Chet Ramey wrote: > On 8/11/16 8:29 AM, Mike Frysinger wrote: > > simple code to reproduce: > > bash -c 'v=$*' > > http://lists.gnu.org/archive/html/bug-bash/2016-07/msg00066.html thanks ... still catching up after vacation and hadn&

Re: [PATCH 5/5] evalstring: drop volatile on sigset

2016-08-11 Thread Mike Frysinger
On 11 Aug 2016 11:45, Chet Ramey wrote: > On 8/11/16 8:30 AM, Mike Frysinger wrote: > > These variables are located on the stack and are never read/written > > directly by bash. Instead, they're all accessed indirectly via the > > POSIX signal API. Since POSIX does not

Re: popd controlled free (Segmentation fault) with bash 4.2.47, 4.3.48, and 4.4.5

2016-11-25 Thread Mike Frysinger
Segmentation fault) in all bash versions here > > around > > This has been fixed for a couple of weeks in the devel branch. can you cut a patch ? -mike signature.asc Description: Digital signature

Re: Another little patch I would like to put upstream

2016-12-05 Thread Mike Frysinger
t;s^!PATCHLEVEL!^$(PatchLevel)^" \ > + -e "s^!MACHTYPE!^$(MACHTYPE)^" -e "s^!RELSTATUS!^$(RELSTATUS)^" \ >$(SUPPORT_SRC)bashbug.sh > $@ > @chmod a+rx bashbug using ^ as an anchor doesn't seem that much better than % autoconf uses & and |, but they tend to do it for vars where it's unlikely those will show up (like path vars) how about something like: @s=$$(printf '\001'); \ sed -e "s$$s!MACHINE!$$s$(Machine)$$s" ... -mike signature.asc Description: Digital signature

Re: Another little patch I would like to put upstream

2016-12-07 Thread Mike Frysinger
On 07 Dec 2016 19:09, Chet Ramey wrote: > On 12/5/16 11:01 PM, Mike Frysinger wrote: > > using ^ as an anchor doesn't seem that much better than % > > Ultimately, autoconf is the right way to do this. sure, you could add bashbug to AC_OUTPUT and adapt all the vars to be

[PATCH] lib/readline/doc makefiles clean targets

2024-10-29 Thread Mike Jonkmans
*.toc *.tp *.vr *.cps *.pgs \ + *.fns *.kys *.tps *.vrs *.bt *.bts install: @echo "This documentation should not be installed." -- Regards, Mike

[PATCH] Makefile.in variables.o: version.h

2024-10-29 Thread Mike Jonkmans
-- Regards, Mike Jonkmans

Re: [PATCH] lib/readline/doc makefiles clean targets

2024-11-04 Thread Mike Jonkmans
On Sun, Nov 03, 2024 at 03:28:27PM -0500, Chet Ramey wrote: > On 11/1/24 6:20 PM, Mike Jonkmans wrote: > > On Fri, Nov 01, 2024 at 01:25:46PM -0400, Chet Ramey wrote: > > > On 10/29/24 1:04 PM, Mike Jonkmans wrote: > > > > Hi Chet et al., > > >

Re: [PATCH] lib/readline/doc makefiles clean targets

2024-11-01 Thread Mike Jonkmans
On Fri, Nov 01, 2024 at 01:25:46PM -0400, Chet Ramey wrote: > On 10/29/24 1:04 PM, Mike Jonkmans wrote: > > Hi Chet et al., > > > > If I run, on devel (4917f285): > > - ./configure > > - make > > - make clean > > - git status > > > > I w

Re: [PATCH] lib/readline/doc makefiles clean targets

2024-11-08 Thread Mike Jonkmans
On Thu, Nov 07, 2024 at 06:05:36PM -0500, Chet Ramey wrote: > On 11/4/24 9:44 AM, Mike Jonkmans wrote: > > > > > According to info (make)Standard Targets, we should have: > > > > mostlyclean < clean < distclean < maintainer-clean > > &

Re: [PATCH] Makefile: avoid undefined variables

2024-10-26 Thread Mike Jonkmans
nfigure --with and --enable options. Like --with-bash-malloc --with-curses, --with-installed-readline. I am not sure if the research to do that is worth the trouble. So the above 'fixed' version would be fine with me. -- Regards, Mike

redirection / process substitution fails to read a file descriptor

2024-11-16 Thread Mike Peters
hough it works when pulling from a file directly. In the below sample shell session, it is expected that `<( echo foobar > test.txt > echo `< <( exec 3 cat <&3 foobar > exec 3 echo `< <(<&3)` > Mike Peters

Re: [PATCH] lib/readline/doc makefiles clean targets

2024-11-14 Thread Mike Jonkmans
On Mon, Nov 11, 2024 at 03:30:53PM -0500, Chet Ramey wrote: > On 11/8/24 4:15 PM, Mike Jonkmans wrote: > > > > 2) The use of recursive make, makes it harder to do dependencies right; > > > It's the best way to build using optional components and subdirectories. >

Re: String substitution bug

2024-11-26 Thread Mike Jonkmans
o solve in a restricted cli-environment. It was nice when starting to learn scripting. Unfortunately it has gone off the radar. This comes close: https://www.learnshell.org/ -- Regards, Mike Jonkmans

Re: PIPESTATUS differs from $? for compound command

2024-12-09 Thread Mike Jonkmans
27;, the whole if has 0 as status, due to #1. The last pipeline is the 'false' command. So $PIPESTATUS = 1. Both other examples, e.g. 'if false; then :; fi | true', are, for PIPESTATUS purposes, equivalent to: 'true | true'. -- Regards, Mike Jonkmans

Re: PIPESTATUS differs from $? for compound command

2024-12-09 Thread Mike Jonkmans
On Mon, Dec 09, 2024 at 09:20:54PM +0100, Andreas Schwab wrote: > On Dez 09 2024, Mike Jonkmans wrote: > > So, with 'if false; then :; fi', the whole if has 0 as status, due to #1. > > The last pipeline is the 'false' command. So $PIPESTATUS = 1. > Why is `if

Re: PIPESTATUS differs from $? for compound command

2024-12-11 Thread Mike Jonkmans
On Tue, Dec 10, 2024 at 05:10:08PM -0500, Chet Ramey wrote: > On 12/10/24 4:41 AM, Mike Jonkmans wrote: > > > Also compare: > > $ if false; then echo foo; fi > > $ echo "ret = $?, status = ${PIPESTATUS[*]}" > > ret = 0, status = 1 >

Re: PIPESTATUS differs from $? for compound command

2024-12-10 Thread Mike Jonkmans
On Mon, Dec 09, 2024 at 11:33:02PM +0100, Andreas Schwab wrote: > On Dez 09 2024, Mike Jonkmans wrote: > > > But the PIPESTATUS refers to the 'false' pipeline: > > $ if false; then :; fi; echo ${PIPESTATUS[*]} > > 1 > > $ if false; then :; fi | tr

Re: PIPESTATUS differs from $? for compound command

2024-12-10 Thread Mike Jonkmans
On Tue, Dec 10, 2024 at 09:28:31AM +0100, Ulrich Müller wrote: > >>>>> On Mon, 09 Dec 2024, Mike Jonkmans wrote: > > >> Why is `if false; then :; fi' not a pipeline? It is a command, and the > >> components of a pipeline are commands. > > &g

Re: PIPESTATUS differs from $? for compound command

2024-12-11 Thread Mike Jonkmans
On Wed, Dec 11, 2024 at 07:44:02PM -0500, Lawrence Velázquez wrote: > On Wed, Dec 11, 2024, at 3:50 AM, Mike Jonkmans wrote: > > Or worse: '! true | ! true' is a syntax error!? > > Also errors in dash, but not in ksh. > > Can a command - as part of a pipeline - no

Re: PIPESTATUS differs from $? for compound command

2024-12-12 Thread Mike Jonkmans
On Thu, Dec 12, 2024 at 03:56:52AM -0500, Lawrence Velázquez wrote: > On Thu, Dec 12, 2024, at 2:01 AM, Mike Jonkmans wrote: > > Yes, the posix grammar doesn't allow it. > > But it is not clear, from the bash documentation, > > that a pipeline is not a command. > Su

Re: redirection / process substitution fails to read a file descriptor

2024-11-17 Thread Mike Peters
On 2024-11-16 20:35, Greg Wooledge wrote: On Sat, Nov 16, 2024 at 16:35:05 -0600, Mike Peters wrote: Description: Process substitution does not generate properly when pulling from another file descriptor, although it works when pulling from a file directly. In the below sample shell

Re: redirection / process substitution fails to read a file descriptor

2024-11-17 Thread Mike Peters
On 2024-11-16 22:56, Lawrence Velázquez wrote: On Sat, Nov 16, 2024, at 9:35 PM, Greg Wooledge wrote: On Sat, Nov 16, 2024 at 16:35:05 -0600, Mike Peters wrote: Description: Process substitution does not generate properly when pulling from another file descriptor, although it works

<    1   2   3   4   5   6