Re: [PATCH] Makefile: avoid undefined variables

2024-10-25 Thread Martin D Kealey
On Fri, 25 Oct 2024 at 05:07, Grisha Levit wrote: > These are reported by make --warn-undefined-variables. > > Most were being set previously (sometimes 20 years ago) and got left > behind in recepies after their definitions have been removed. Others > only get set in some configurations so it ma

Re: [PATCH] BASH_STRUCT_DIRENT*: simplify

2024-10-25 Thread Chet Ramey
On 10/23/24 1:34 PM, Grisha Levit wrote: The BASH_STRUCT_DIRENT* macros duplicate the caching, message printing, and defining functionality already present in the AC_CHECK_MEMBERS macro that gets called. Thanks for the report and patch. -- ``The lyf so short, the craft so long to lerne.'' - Ch

Re: [PATCH] BASH_FUNC_STRTOIMAX: fix and simplify

2024-10-25 Thread Chet Ramey
On 10/23/24 12:39 PM, Grisha Levit wrote: Without an existing cache, if we run ./configure -C, we get the odd- looking: checking for usable strtoimax... checking for strtoimax... yes checking whether strtoimax is declared... yes yes Thanks for the report. I'll take a look here.

Re: [PATCH] Makefile: avoid undefined variables

2024-10-25 Thread Dmitry Goncharov
>- cd $(@D) && $(MAKE) BUILD_DIR=$(UP)$(BUILD_DIR) >top_srcdir=$(UPSRC)$(top_srcdir) $(MAKEFLAGS) $(@F) It is really not a good idea to pass makeflags on the command line as a positional parameter. A variable (any variable, including makeflags) set on the command line, overrides the value

Re: posix vs default mode nonsense

2024-10-25 Thread Zachary Santer
On Tue, Oct 22, 2024 at 11:30 AM Chet Ramey wrote: > > but that won't help with the portability problems. You can't even use arrays or [[ ... ]] and be portable, right? It might be easier to install bash on whatever it is at that point.