Re: [PATCH] use unlocked stdio functions

2024-02-14 Thread Chet Ramey
On 2/5/24 10:47 PM, Grisha Levit wrote: Bash makes many calls to stdio functions that may have unlocked_stdio(3) equivalents. Since the locking functionality provided by the regular versions is only useful in multi-threaded applications, it probably makes sense for Bash to use the *_unlocked vers

Re: [PATCH] use unlocked stdio functions

2024-02-14 Thread Vito Caputo
On Wed, Feb 14, 2024 at 10:59:57AM -0500, Chet Ramey wrote: > On 2/5/24 10:47 PM, Grisha Levit wrote: > > Bash makes many calls to stdio functions that may have unlocked_stdio(3) > > equivalents. Since the locking functionality provided by the regular > > versions is only useful in multi-threaded a

Re: [PATCH] use unlocked stdio functions

2024-02-14 Thread Chet Ramey
On 2/14/24 11:18 AM, Vito Caputo wrote: On Wed, Feb 14, 2024 at 10:59:57AM -0500, Chet Ramey wrote: On 2/5/24 10:47 PM, Grisha Levit wrote: Bash makes many calls to stdio functions that may have unlocked_stdio(3) equivalents. Since the locking functionality provided by the regular versions is o

Re: [PATCH] Fix minor portability issues including ISO C 23 prototypes.

2024-02-14 Thread Chet Ramey
On 2/14/24 12:26 AM, Collin Funk wrote: Hi, I noticed some compiler warnings that might be worth fixing. I wasn't sure if patches should have ChangeLog entries so I left it alone and tried to make it easy to copy paste for you. Feel free to use or ignore changes as you see fit. Thanks for the p

Re: [PATCH] Fix minor portability issues including ISO C 23 prototypes.

2024-02-14 Thread Collin Funk
On 2/14/24 11:56 AM, Chet Ramey wrote: > This isn't necessary in general; ISO C guarantees that a constant > expression with value 0 is a null pointer constant just like NULL, > and the compiler will make them equivalent even if the internal > representation of a null pointer isn't all zeroes. Oop