Re: [PATCH] small doc typos

2023-11-24 Thread Chet Ramey
On 11/21/23 6:37 PM, Grisha Levit wrote: diff --git a/doc/bash.1 b/doc/bash.1 Thanks for the report. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet

Re: [PATCH] tests/unicode1.sub: fixup

2023-11-24 Thread Chet Ramey
On 11/22/23 7:46 PM, Grisha Levit wrote: Many of the tests in unicode.sub don't actually run because the arrays containing codepoints to test are sparse and the TestCodePage function assumes that they are not. Thanks for the report. Nice attention to detail. This test has not changed substantia

tests/glob2.sub failure on macOS 14

2023-11-24 Thread Grisha Levit
In macOS 14 (Sonoma), Apple switched from GNU to BSD-based iconv, which have slightly different charset definitions. The tests in glob2.sub test U+03B1 in zh_HK.big5hkscs, but this codepoint is not present in the BSD BIG5-HKSCS definition, so the test fails. The codepoint does exist in the BIG5 ch

Many of the example loadable builtins don't work anymore

2023-11-24 Thread Emanuele Torre
Many of the loadable builtins that set variables in the examples/loadables directory don't work anymore because they still want to call legal_identifier instead of valid_identifier. $ ./bash -c 'enable -f {examples/loadables/,}mktemp; mktemp' /tmp/shtmp.h2HpWZ $ ./bash -c 'enable -f {e

Re: Many of the example loadable builtins don't work anymore

2023-11-24 Thread Emanuele Torre
I've noticed that a lib/sh/compat.c file was added that still provides the declaration for the legacy legal_ functions. The bash executable I was getting from building the devel branch did not have those symbols though. The reason was that lib/sh/Makefile was not getting regenerated, so the recip

Re: [PATCH] tests/unicode1.sub: fixup

2023-11-24 Thread Grisha Levit
On Fri, Nov 24, 2023, 17:32 Chet Ramey wrote: > Thanks for the report. Nice attention to detail. This test has not changed > substantially since it was donated in 2012. Namerefs didn't exist then, and > my guess is that John Kearney wasn't familiar or comfortable with ${!x[@]}. > > https://lists.

Re: Many of the example loadable builtins don't work anymore

2023-11-24 Thread Emanuele Torre
On Sat, Nov 25, 2023 at 04:32:36AM +0100, Emanuele Torre wrote: > I've noticed that a lib/sh/compat.c file was added that still provides > the declaration for the legacy legal_ functions. > > The bash executable I was getting from building the devel branch did not > have those symbols though. > >