Re: `verb=(--) declare -ax verb` causes an ENOTSOCK segfault

2023-06-16 Thread Lawrence Velázquez
On Fri, Jun 16, 2023, at 1:02 AM, Wiley Young wrote: > Description: >`verb=(--) declare -ax verb` causes bash to crash and closes the active > terminal tab. The value "(--)" does not seem to be necessary: % /bin/bash -c 'foo= declare -ax foo' zsh: segmentation fault /bin/bash -c 'foo= declar

Re: `verb=(--) declare -ax verb` causes an ENOTSOCK segfault

2023-06-16 Thread Greg Wooledge
On Fri, Jun 16, 2023 at 10:59:24AM -0400, Lawrence Velázquez wrote: > % /bin/bash -c 'foo= declare -ax foo' > zsh: segmentation fault /bin/bash -c 'foo= declare -ax foo' > > I am seeing this behavior with bash 3.2.57, so it appears to be > longstanding. I get a segfault/core dump in every versio

Re: 5.2 fails to treat a missing conditional expression as an error of syntax

2023-06-16 Thread Chet Ramey
On 6/15/23 8:57 PM, Kerin Millar wrote: As below. $ bash -c 'declare -p BASH_VERSION' declare -- BASH_VERSION="5.2.15(1)-release" $ bash -c '[[ ]]; echo fin'; echo $? 0 https://lists.gnu.org/archive/html/bug-bash/2022-10/msg00103.html describes the fix. We had this same discussion back in Feb

Re: `jobs` shows output even when nothing has been started in the background

2023-06-16 Thread Chet Ramey
On 6/14/23 6:12 PM, Ajeet D'Souza wrote: Hey Chet, Thanks for the quick reply. I have some follow-up questions: * Is there an elegant way I can start an external process without it showing up under jobs, even on affected versions? My current best idea is: (_="$(/bin/echo)"; jobs -l)

Re: `jobs` shows output even when nothing has been started in the background

2023-06-16 Thread Ajeet D'Souza
Hi, Thanks for all the help! I created a PR with this workaround on the Starship repository: https://github.com/starship/starship/pull/5253 Regards, Ajeet On Sat, Jun 17, 2023 at 12:00 AM Chet Ramey wrote: > On 6/14/23 6:12 PM, Ajeet D'Souza wrote: > > Hey Chet, > > > > Thanks for the quick re

bug-bash@gnu.org

2023-06-16 Thread Chet Ramey
On 6/10/23 7:31 PM, Grisha Levit wrote: The command printing code can fail to add a required semicolon when the last word in the command ends with `&' Thanks for the report and patch. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis

bug-bash@gnu.org

2023-06-16 Thread Chet Ramey
On 6/10/23 10:41 PM, Martin D Kealey wrote: On Sun, 11 Jun 2023, 09:31 Grisha Levit, wrote: The command printing code can fail to add a required semicolon when the last word in the command ends with `&' This could be obviated by unconditionally outputting a newline instead of a semicolon.

Re: posix_spawn (or vfork) support?

2023-06-16 Thread Chet Ramey
On 6/15/23 8:32 PM, Sam James wrote: Hi, Sorry if this has come up before - I did take a look and couldn't find anything. Could bash use posix_spawn/vfork instead of the rather heavyweight fork? I haven't looked at them. Bash does more work between fork and exec than the posix_spawn implement

Re: 5.2 fails to treat a missing conditional expression as an error of syntax

2023-06-16 Thread Kerin Millar
On Fri, 16 Jun 2023 14:25:54 -0400 Chet Ramey wrote: > On 6/15/23 8:57 PM, Kerin Millar wrote: > > As below. > > > > $ bash -c 'declare -p BASH_VERSION' > > declare -- BASH_VERSION="5.2.15(1)-release" > > $ bash -c '[[ ]]; echo fin'; echo $? > > 0 > > https://lists.gnu.org/archive/html/bug-bash

[PATCH] fix compgen -V leak

2023-06-16 Thread Grisha Levit
My earlier patch for adding compgen -V did the variable assignment in a pretty silly way and had a small memory leak to boot. Hope this new way makes sense, sorry for the extra work. --- >From b6b13b89e1436ddd575483a81e79ef43d82a5c0c Mon Sep 17 00:00:00 2001 From: Grisha Levit Date: Sat, 3 Jun 202

[PATCH] uninitialized variable access

2023-06-16 Thread Grisha Levit
Some uninitialized variable access identified by clang's static analyzer. (FWIW 90% of the reports were bogus but these seem legit) * lib/readline/input.c - rl_gather_tyi: the `result' variable is no longer initialized before first access since commit d0bc56a32 * lib/readline/kill.c - _rl_read_br

[PATCH] null pointer deref in bindpwd

2023-06-16 Thread Grisha Levit
Only triggered by doing something stupid: bash -c 'declare -n OLDPWD=X[SHLVL=-1]; /; cd /' bash: line 1: X[SHLVL=-1]: bad array subscript Segmentation fault: 11 --- diff --git a/builtins/cd.def b/builtins/cd.def index de123f8b..e3156463 100644 --- a/builtins/cd.def +++ b/builtins/cd.def @@ -158,1