Re: segfault on initial word completion

2023-04-28 Thread Chet Ramey
On 4/21/23 1:15 PM, Grisha Levit wrote: One more issue after the fix, the start can end up being further than pcomp_ind Thanks for the follow up. We have to distinguish between lines with only whitespace following any assignment statements and other non-empty lines. Chet -- ``The lyf so shor

Re: heap-buffer-overflow in history_expand

2023-04-28 Thread Chet Ramey
On 4/24/23 1:40 AM, Grisha Levit wrote: The history expansion code can end up reading past the end of the input line buffer if the line ends with an invalid multibyte sequence: Thanks for the report. You mean an incomplete multibyte character, I think. Chet -- ``The lyf so short, the craft so

Re: [PATCH] allow quoting completions w/o filename treatment

2023-04-28 Thread Chet Ramey
On 4/14/23 5:20 PM, Grisha Levit wrote: Currently, there isn't any way to request quoting of completion matches without getting also the attendant filename treatment. Thanks for the patch. This, or something like it, has been on the list since konsolebox proposed it in February, 2022. Chet --

Integer overflow of i in string_extract_verbatim

2023-04-28 Thread Eric Li
From: Eric Li To: bug-bash@gnu.org Subject: Integer overflow of i in string_extract_verbatim Configuration Information [Automatically generated, do not change]: Machine: x86_64 OS: linux-gnu Compiler: gcc Compilation CFLAGS: -g -Og uname output: Linux fedora 6.2.12-200.fc37.x86_64 #1 SMP PREEMPT_

Re: heap-buffer-overflow in history_expand

2023-04-28 Thread Grisha Levit
On Fri, Apr 28, 2023, 11:35 Chet Ramey wrote: > On 4/24/23 1:40 AM, Grisha Levit wrote: > > The history expansion code can end up reading past the end of the > > input line buffer if the line ends with an invalid multibyte sequence: > > Thanks for the report. You mean an incomplete multibyte char