Re: bug-bash Digest, Vol 142, Issue 53

2014-09-30 Thread Thomas Mellman
bug-bash-requ...@gnu.org wrote: >Send bug-bash mailing list submissions to > bug-bash@gnu.org > >To subscribe or unsubscribe via the World Wide Web, visit > https://lists.gnu.org/mailman/listinfo/bug-bash >or, via email, send a message with subject or body 'help' to > bug-bash-

Re: Detecting invocation as /bin/sh ?

2014-09-30 Thread Alexandre Ferrieux
On Tuesday, September 30, 2014 2:42:33 AM UTC+2, Chet Ramey wrote: > On 9/29/14, 7:53 PM, Alexandre Ferrieux wrote: > > > > [bash -p] *does* disable that embarrassing nightmare of a misfeature that > > is function import: > > I guess if that's what you mean by "just the sh", then yes, it does.

Re: hashlib.c add NULL check for "string" parameter

2014-09-30 Thread Notes Jonny
On Mon, Sep 29, 2014 at 2:04 PM, Chet Ramey wrote: > On 9/29/14, 8:22 AM, Notes Jonny wrote: >> Hello >> I noticed hash_search() did not check if "string" parameter was >> non-NULL. Please find attached a patch for this. > > It's the caller's responsibility to ensure that the string passed to > ha

Re: hashlib.c add NULL check for "string" parameter

2014-09-30 Thread Ángel González
Notes Jonny wrote: > On Mon, Sep 29, 2014 at 2:04 PM, Chet Ramey wrote: > > On 9/29/14, 8:22 AM, Notes Jonny wrote: > >> Hello > >> I noticed hash_search() did not check if "string" parameter was > >> non-NULL. Please find attached a patch for this. > > > > It's the caller's responsibility to ensu

Re: REGRESSION: shellshock patch rejects valid function names

2014-09-30 Thread Eric Blake
On 09/29/2014 08:33 PM, David Korn wrote: > I fixed the bug in ksh that allows you delete a special builtin. Thanks; here's another ksh bug: $ env 'a|b=' bash -c 'set | grep a"."b' $ env 'a|b=' ksh -c 'set | grep a"."b' a|b='' But per the documentation of set, "If no options or arguments are spe

Re: REGRESSION: shellshock patch rejects valid function names

2014-09-30 Thread Eric Blake
On 09/30/2014 08:42 AM, Eric Blake wrote: > Thanks; here's another ksh bug: > > $ env 'a|b=' bash -c 'set | grep a"."b' > $ env 'a|b=' ksh -c 'set | grep a"."b' > a|b='' > > But per the documentation of set, "If no options or arguments are > specified, set shall write the names and values of all

Re: REGRESSION: shellshock patch rejects valid function names

2014-09-30 Thread Stephane Chazelas
2014-09-30 09:04:28 -0600, Eric Blake: > On 09/30/2014 08:42 AM, Eric Blake wrote: > > Thanks; here's another ksh bug: > > > > $ env 'a|b=' bash -c 'set | grep a"."b' > > $ env 'a|b=' ksh -c 'set | grep a"."b' > > a|b='' > > > > But per the documentation of set, "If no options or arguments are >

Re: REGRESSION: shellshock patch rejects valid function names

2014-09-30 Thread Stephane Chazelas
2014-09-30 17:06:22 +0100, Stephane Chazelas: [...] > Same with "export -p": > > $ env -i $'a\necho test\na=b' ksh -c 'export -p' | ksh > test > > And bash is also vulnerable. > > $ env -i $'a\necho test\na=b' bash -c 'export -p' > declare -x OLDPWD > declare -x PWD="/home/stephane" > declare -x

Issue with patching from bash-4.3-patches

2014-09-30 Thread Matthew Gessner
I am having issues with patch working properly with the patches in bash-4.3-patches. I don't do much patching, so this is a bit confusing. I've seen similar issues using patch 2.7.1 and patch 2.6. My two directories are bash-4.3 and bash-4.3-patches. >From inside bash-4.3 and using patch 2.7.1 I

Issue with patching from bash-4.3-patches

2014-09-30 Thread Matthew Gessner
I apologize, but I somehow sent this from gmail prematurely. I am having issues with patch working properly with the patches in bash-4.3-patches. Admittedly, I don't use patch very often, but having asked on freenode ##bash and others telling me they are not having issues, they suggested I post thi

Re: Detecting invocation as /bin/sh ?

2014-09-30 Thread Bob Proulx
Alexandre Ferrieux wrote: > Greg Wooledge wrote: > > Unfortunately, most people don't actually express an intent when they > > use #!/bin/sh. They just copy some code from a random script they found > > somewhere, without understanding what it means. > > That song reminds me of PHP. I was under t