Re: verbosity of DEBUG trap following edit-and-execute-command

2020-04-11 Thread Ami Fischman
On Mon, Apr 6, 2020 at 6:18 AM Chet Ramey wrote: > I'm going to go with a variant of 2: a more general facility that only the > `fc' builtin uses. It will be in the next devel branch push. Thanks! Confirmed that patching trap.{h,c} and builtins/fc.def to reproduce the diffs in those files from h

Re: verbosity of DEBUG trap following edit-and-execute-command

2020-04-06 Thread Chet Ramey
On 4/5/20 8:45 PM, Ami Fischman wrote: > On Sun, Apr 5, 2020 at 12:43 PM Chet Ramey wrote: >> Hence the discussion topic: should bash disable set -v when executing >> the DEBUG trap, should it do that just while running commands from a >> file while running `fc', or should it continue with its cur

Re: verbosity of DEBUG trap following edit-and-execute-command

2020-04-05 Thread Ami Fischman
On Sun, Apr 5, 2020 at 12:43 PM Chet Ramey wrote: > Hence the discussion topic: should bash disable set -v when executing > the DEBUG trap, should it do that just while running commands from a > file while running `fc', or should it continue with its current behavior? Thanks for clarifying the pa

Re: verbosity of DEBUG trap following edit-and-execute-command

2020-04-05 Thread Chet Ramey
On 4/3/20 7:45 PM, Ami Fischman wrote: > On Fri, Apr 3, 2020 at 9:13 AM Chet Ramey wrote: >> Since this is all wrapped up in existing shell features, there's no good >> way to isolate the fc behavior. I've seen suggestions on here to disable >> set -v while running the DEBUG trap unconditionally,

Re: verbosity of DEBUG trap following edit-and-execute-command

2020-04-03 Thread Ami Fischman
On Fri, Apr 3, 2020 at 9:13 AM Chet Ramey wrote: > Since this is all wrapped up in existing shell features, there's no good > way to isolate the fc behavior. I've seen suggestions on here to disable > set -v while running the DEBUG trap unconditionally, like ksh93 does. I've found https://groups.

Re: verbosity of DEBUG trap following edit-and-execute-command

2020-04-03 Thread Chet Ramey
On 4/2/20 12:50 PM, Ami Fischman wrote: > After the editor invoked by edit-and-execute-command exits, the > about-to-be-executed command (as edited by the editor) is echoed, but > seemingly > as if [set -v] was set, causing a command executed before the edited command > as > the result of a trap

verbosity of DEBUG trap following edit-and-execute-command

2020-04-02 Thread Ami Fischman
After the editor invoked by edit-and-execute-command exits, the about-to-be-executed command (as edited by the editor) is echoed, but seemingly as if [set -v] was set, causing a command executed before the edited command as the result of a trap DEBUG to be echoed, as well. This is annoying for exam