Re: savestring() macro in general.h runs function arguments twice.

2012-11-26 Thread Chet Ramey
On 11/24/12 2:32 AM, John E. Malmberg wrote: > The execute_cmd.c module uses make_command_string() as a parameter to the > savestring() macro. > > This causes the savestring() macro to call that function twice(). Thanks, good catch. I made the same temporary variable fix you did. > I have not d

savestring() macro in general.h runs function arguments twice.

2012-11-23 Thread John E. Malmberg
The execute_cmd.c module uses make_command_string() as a parameter to the savestring() macro. This causes the savestring() macro to call that function twice(). I have not done any timing tests to see how this is impacting performance, but it definitely shows up when stepping through commands