Re: make test errata (part 3)

2025-01-02 Thread Oğuz
On Thursday, January 2, 2025, Martin D Kealey wrote: > > On Thu, 2 Jan 2025 at 14:25, Oğuz wrote: > >> I don't see any upsides either. What's the point? >> > > New features don't have to make sense to everyone > If adding that feature involves merging 5k lines of unaudited code it should do mor

Re: make test errata (part 3)

2025-01-01 Thread Oğuz
On Thursday, January 2, 2025, Martin D Kealey wrote: > > Do you see any downsides to this approach? > I don't see any upsides either. What's the point? -- Oğuz

Re: make test errata (part 3)

2025-01-01 Thread Martin D Kealey
tests/run-all goes to some trouble to unset and/or unexport SHELLOPTS, but it ignores BASHOPTS, which seems equally problematic. This can be demonstrated by running « env BASHOPTS=dotglob:extglob:gnu_errfmt:lastpipe:login_shell:nocaseglob:nocasematch:nullglob:shift_verbose:compat31 make tests » (I

Re: make test errata

2024-12-27 Thread Chet Ramey
On 12/14/24 6:18 AM, Martin D Kealey wrote: Where there are some “expected” differences, could these be filtered? In particular, - sort the output of “trap” alphabetically, rather than leave it in numeric signal-number order? I'll look at this, this might be useful. - compare wh

Re: make test errata (part 2)

2024-12-19 Thread Chet Ramey
On 12/14/24 9:35 AM, Martin D Kealey wrote: (see first part for background) I've patched Bash to merge “shopt” and “set -o”, and now “make tests” reports some minor differences. I would like some feedback on whether they're significant enough to warrant fixing. I never did hear why exactly you

Re: make test errata

2024-12-18 Thread Chet Ramey
On 12/14/24 6:18 AM, Martin D Kealey wrote: I'm trying to make sure that my modified version of Bash passes all the tests, and in the process I'm finding some, erm, oddities. Firstly, what seems to be a bug: Looking in tests/printf7.sub it has INT_MAX=$(getconf INT_MAX 2>/dev/null) [ -z "$INT_M