Re: logic in m4/strtoimax.m4 inverted

2024-05-14 Thread Evan Gates
On Mon, Oct 3, 2022 at 12:48 PM Chet Ramey wrote: > > On 10/1/22 6:38 AM, Emanuel Haupt wrote: > > Static build of 5.2 fails to build on FreeBSD 13.1-RELEASE (amd64). > > > > The logic in m4/strtoimax.m4 is inverted. The following patch replaces > > strtoimax() if and only if it is present and fun

Re: logic in m4/strtoimax.m4 inverted

2024-05-14 Thread Chet Ramey
On 5/14/24 11:17 AM, Evan Gates wrote: On Mon, Oct 3, 2022 at 12:48 PM Chet Ramey wrote: On 10/1/22 6:38 AM, Emanuel Haupt wrote: Static build of 5.2 fails to build on FreeBSD 13.1-RELEASE (amd64). The logic in m4/strtoimax.m4 is inverted. The following patch replaces strtoimax() if and only

Re: logic in m4/strtoimax.m4 inverted

2022-10-04 Thread Chet Ramey
On 10/4/22 3:24 AM, Emanuel Haupt wrote: I wonder why it fails to link, though. FreeBSD must have another function (probably strtoll) that bash uses defined in that same source file. Otherwise, wouldn't static linking skip the libc definition? FreeBSD has both: https://www.freebsd.org/cgi/man.

Re: logic in m4/strtoimax.m4 inverted

2022-10-04 Thread Emanuel Haupt
Chet Ramey wrote: > On 10/1/22 6:38 AM, Emanuel Haupt wrote: > > Static build of 5.2 fails to build on FreeBSD 13.1-RELEASE (amd64). > > > > The logic in m4/strtoimax.m4 is inverted. The following patch > > replaces strtoimax() if and only if it is present and functional. > > Thanks for the repo

Re: logic in m4/strtoimax.m4 inverted

2022-10-03 Thread Chet Ramey
On 10/1/22 6:38 AM, Emanuel Haupt wrote: Static build of 5.2 fails to build on FreeBSD 13.1-RELEASE (amd64). The logic in m4/strtoimax.m4 is inverted. The following patch replaces strtoimax() if and only if it is present and functional. Thanks for the report. You're right, of course. I wonder