Re: bash: Correct usage of F_SETFD

2010-11-26 Thread Jamie Lokier
Eric Blake wrote: > On 11/22/2010 03:16 PM, Chet Ramey wrote: > >> include/filecntl.h in bash-4.1 has following: > >> > >> #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) > >> > >> Is that really the correct/intended usage of F_SETFD ? > > > > F_SETFDSet the clo

Re: bash: Correct usage of F_SETFD

2010-11-23 Thread Matthew Wilcox
On Mon, Nov 22, 2010 at 04:04:46PM -0800, Sukadev Bhattiprolu wrote: > Eric Blake [ebl...@redhat.com] wrote: > | On 11/22/2010 03:16 PM, Chet Ramey wrote: > | >> include/filecntl.h in bash-4.1 has following: > | >> > | >> #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) > | >> > |

Re: bash: Correct usage of F_SETFD

2010-11-23 Thread Sukadev Bhattiprolu
Eric Blake [ebl...@redhat.com] wrote: | > | > So if bash is the one creating its file descriptors, there's no need to | > use R/M/W since it knows what the state of them are. | | No, bash cannot reasonably know what the implementation's default bit | state is, and blindly setting all other bits t

Re: bash: Correct usage of F_SETFD

2010-11-23 Thread Eric Blake
On 11/23/2010 07:42 AM, Matthew Wilcox wrote: > The POSIX definition can be found here: > http://www.opengroup.org/onlinepubs/009695399/functions/fcntl.html > >> | In practice, there aren't any such systems; but POSIX warns that current >> | practice is no indicator of future systems, and that rea

Re: bash: Correct usage of F_SETFD

2010-11-22 Thread Sukadev Bhattiprolu
Eric Blake [ebl...@redhat.com] wrote: | On 11/22/2010 03:16 PM, Chet Ramey wrote: | >> include/filecntl.h in bash-4.1 has following: | >> | >> #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) | >> | >> Is that really the correct/intended usage of F_SETFD ? | > | > F_SETFD

Re: bash: Correct usage of F_SETFD

2010-11-22 Thread Eric Blake
On 11/22/2010 03:16 PM, Chet Ramey wrote: >> include/filecntl.h in bash-4.1 has following: >> >> #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) >> >> Is that really the correct/intended usage of F_SETFD ? > > F_SETFDSet the close-on-exec flag associated with fi

Re: bash: Correct usage of F_SETFD

2010-11-22 Thread Chet Ramey
> include/filecntl.h in bash-4.1 has following: > > #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) > > Is that really the correct/intended usage of F_SETFD ? F_SETFDSet the close-on-exec flag associated with fildes to the low order bit