Re: [PATCH] normalization tweaks for macOS

2023-07-31 Thread Grisha Levit
On Mon, Jul 31, 2023, 10:32 Chet Ramey wrote: > On 7/25/23 4:06 PM, Grisha Levit wrote: > > Re latest changes in [1], we need to preserve quoting also for any of > > the following characters, at least if they are in a bracket > > expression: > > ! - . : = ^ > > Why not just quote them all the tim

Re: [PATCH] normalization tweaks for macOS

2023-07-31 Thread Chet Ramey
On 7/25/23 4:06 PM, Grisha Levit wrote: On Mon, Jul 24, 2023 at 10:12 AM Chet Ramey wrote: On 7/20/23 7:52 PM, Grisha Levit wrote: I wonder if you'd be interested in changes to the function that would skip escaping ASCII characters that aren't glob-special as well. I _think_ it would just b

Re: [PATCH] normalization tweaks for macOS

2023-07-25 Thread Grisha Levit
On Mon, Jul 24, 2023 at 10:12 AM Chet Ramey wrote: > > On 7/20/23 7:52 PM, Grisha Levit wrote: > > > I wonder if you'd be interested in changes > > to the function that would skip escaping ASCII characters that aren't > > glob-special as well. I _think_ it would just be a slight variation > > of

Re: [PATCH] normalization tweaks for macOS

2023-07-24 Thread Chet Ramey
On 7/20/23 7:52 PM, Grisha Levit wrote: I wonder if you'd be interested in changes to the function that would skip escaping ASCII characters that aren't glob-special as well. I _think_ it would just be a slight variation of the code that already does this for regexes but I haven't thought about

Re: [PATCH] normalization tweaks for macOS

2023-07-20 Thread Grisha Levit
On Thu, Jul 20, 2023 at 11:54 AM Chet Ramey wrote: > So I'll go ahead with your patch, starting with the globbing changes. Thanks! BTW, changing quote_string_for_globbing to skip escaping characters that don't need it makes globbing >2x faster in the case that most of the pattern is a quoted stri

Re: [PATCH] normalization tweaks for macOS

2023-07-20 Thread alex xmb ratchev
On Thu, Jul 20, 2023, 5:55 PM Chet Ramey wrote: > On 7/18/23 1:39 PM, Grisha Levit wrote: > > On Tue, Jul 18, 2023 at 9:55 AM Chet Ramey wrote: > >> Unicode normalization on macOS has always been a pain in the ass. > > > > I can see that! > > > >> This is the basic assumption that drives all the

Re: [PATCH] normalization tweaks for macOS

2023-07-20 Thread Chet Ramey
On 7/18/23 1:39 PM, Grisha Levit wrote: On Tue, Jul 18, 2023 at 9:55 AM Chet Ramey wrote: Unicode normalization on macOS has always been a pain in the ass. I can see that! This is the basic assumption that drives all the decisions: character input you get from the terminal is in NFC, and fi

Re: [PATCH] normalization tweaks for macOS

2023-07-18 Thread Grisha Levit
On Tue, Jul 18, 2023 at 9:55 AM Chet Ramey wrote: > Unicode normalization on macOS has always been a pain in the ass. I can see that! > This is the basic assumption that drives all the decisions: character input > you get from the terminal is in NFC, and files from the file system (names > and u

Re: [PATCH] normalization tweaks for macOS

2023-07-18 Thread Chet Ramey
On 7/17/23 6:12 PM, Grisha Levit wrote: On Mon, Jul 17, 2023 at 3:29 PM Chet Ramey wrote: On 7/7/23 5:05 PM, Grisha Levit wrote: A few small tweaks for the macOS-specific normalization handling to handle the issues below: The issue is that the behavior has to be different between cases wher

Re: [PATCH] normalization tweaks for macOS

2023-07-18 Thread alex xmb ratchev
i no much here the topic .. just for short .. i found uconv of icu-devtools has more opts has also some transliteration opt just that u may not know it i no pro i still cant achieve what i had to do On Tue, Jul 18, 2023, 12:13 AM Grisha Levit wrote: > On Mon, Jul 17, 2023 at 3:29 PM Chet Ramey

Re: [PATCH] normalization tweaks for macOS

2023-07-17 Thread Grisha Levit
On Mon, Jul 17, 2023 at 3:29 PM Chet Ramey wrote: > > On 7/7/23 5:05 PM, Grisha Levit wrote: > > A few small tweaks for the macOS-specific normalization handling to > > handle the issues below: > > The issue is that the behavior has to be different between cases where > the shell is reading input

Re: [PATCH] normalization tweaks for macOS

2023-07-17 Thread Chet Ramey
On 7/7/23 5:05 PM, Grisha Levit wrote: A few small tweaks for the macOS-specific normalization handling to handle the issues below: The issue is that the behavior has to be different between cases where the shell is reading input from the terminal and gets NFC characters that need to be convert