Re: Change in SIGTERM behaviour in bash 4.3 when using readline

2020-03-04 Thread Chet Ramey
On 3/4/20 2:29 PM, Chris Down wrote: > Ah, it's been a while since I did this and I forgot about the granularity > of the devel branch :-) > > There it bisects to 73a146bec7f75da9f78f6d54329c980b75a2318d ("commit > bash-20130215 snapshot"). I'm pretty sure it's related to this change to > add the

Re: Change in SIGTERM behaviour in bash 4.3 when using readline

2020-03-04 Thread Greg Wooledge
On Wed, Mar 04, 2020 at 03:43:26PM -0500, Chet Ramey wrote: > On 3/4/20 2:38 PM, Chris Down wrote: > > --- a/jobs.c > > +++ b/jobs.c > > @@ -4584,6 +4584,7 @@ initialize_job_signals () > >    if (interactive) > > { > >    set_signal_handler (SIGINT, sigint_sighandler); > > +  set_signa

Re: Change in SIGTERM behaviour in bash 4.3 when using readline

2020-03-04 Thread Chet Ramey
On 3/4/20 2:38 PM, Chris Down wrote: > Chris Down writes: >> I'm not quite sure how best to handle this, maybe setting SIG_IGN as the >> default signal handler for interactive shells if there's nothing to >> inherit? This is one of those cases where SA_RESTART doesn't quite mimic >> SIG_IGN... > >

Re: Change in SIGTERM behaviour in bash 4.3 when using readline

2020-03-04 Thread Chris Down
Chris Down writes: I'm not quite sure how best to handle this, maybe setting SIG_IGN as the default signal handler for interactive shells if there's nothing to inherit? This is one of those cases where SA_RESTART doesn't quite mimic SIG_IGN... This seems too simple, so I assume it's going to

Re: Change in SIGTERM behaviour in bash 4.3 when using readline

2020-03-04 Thread Chris Down
Ah, it's been a while since I did this and I forgot about the granularity of the devel branch :-) There it bisects to 73a146bec7f75da9f78f6d54329c980b75a2318d ("commit bash-20130215 snapshot"). I'm pretty sure it's related to this change to add the signal handler inside initialize_shell_signal

Change in SIGTERM behaviour in bash 4.3 when using readline

2020-03-04 Thread Chris Down
Hi there, A question on Unix & Linux Stack Exchange[0] brought up the question of SIGTERM terminating interactive bash shells. This surprised me, and after bisecting I narrowed it down to commit ac50fbac ("Bash-4.3 distribution sources and documentation"). Going through the commit I see a si