Re: [PATCH 5/5] evalstring: drop volatile on sigset

2016-08-11 Thread Chet Ramey
On 8/11/16 12:12 PM, Mike Frysinger wrote: > On 11 Aug 2016 11:45, Chet Ramey wrote: >> On 8/11/16 8:30 AM, Mike Frysinger wrote: >>> These variables are located on the stack and are never read/written >>> directly by bash. Instead, they're all accessed indirectly via the >>> POSIX signal API. Si

Re: [PATCH 5/5] evalstring: drop volatile on sigset

2016-08-11 Thread Mike Frysinger
On 11 Aug 2016 11:45, Chet Ramey wrote: > On 8/11/16 8:30 AM, Mike Frysinger wrote: > > These variables are located on the stack and are never read/written > > directly by bash. Instead, they're all accessed indirectly via the > > POSIX signal API. Since POSIX does not require volatile, and bash

Re: [PATCH 5/5] evalstring: drop volatile on sigset

2016-08-11 Thread Chet Ramey
On 8/11/16 8:30 AM, Mike Frysinger wrote: > These variables are located on the stack and are never read/written > directly by bash. Instead, they're all accessed indirectly via the > POSIX signal API. Since POSIX does not require volatile, and bash > itself doesn't require volatile, drop the vola

[PATCH 5/5] evalstring: drop volatile on sigset

2016-08-11 Thread Mike Frysinger
These variables are located on the stack and are never read/written directly by bash. Instead, they're all accessed indirectly via the POSIX signal API. Since POSIX does not require volatile, and bash itself doesn't require volatile, drop the volatile markings. If we don't, you get a lot of warn