Re: [PATCH] Add nofirstword completion option

2018-06-19 Thread Chet Ramey
On 6/19/18 10:27 AM, Luca Boccassi wrote: > On Tue, 2018-06-12 at 15:18 -0400, Chet Ramey wrote: >> On 6/12/18 3:15 PM, Luca Boccassi wrote: >> >>> In case it can be somewhat useful, once 5.0-beta with the new >>> option is >>> out I'll ask QA at $work to run regressions tests on it and report >>>

Re: [PATCH] Add nofirstword completion option

2018-06-19 Thread Luca Boccassi
On Tue, 2018-06-12 at 15:18 -0400, Chet Ramey wrote: > On 6/12/18 3:15 PM, Luca Boccassi wrote: > > > In case it can be somewhat useful, once 5.0-beta with the new > > option is > > out I'll ask QA at $work to run regressions tests on it and report > > back > > in case any issues are found. They h

Re: [PATCH] Add nofirstword completion option

2018-06-12 Thread Luca Boccassi
On Tue, 2018-06-12 at 14:54 -0400, Chet Ramey wrote: > On 6/12/18 1:28 PM, Luca Boccassi wrote: > > On Fri, 2018-06-08 at 11:03 -0400, Chet Ramey wrote: > > > On 6/8/18 10:40 AM, Luca Boccassi wrote: > > > > > > > Any chance you had a sec to look at the diff? Would love some > > > > feedback! > >

Re: [PATCH] Add nofirstword completion option

2018-06-12 Thread Chet Ramey
On 6/12/18 3:15 PM, Luca Boccassi wrote: > In case it can be somewhat useful, once 5.0-beta with the new option is > out I'll ask QA at $work to run regressions tests on it and report back > in case any issues are found. They have a lot of tests for the command > line interface (not just related t

Re: [PATCH] Add nofirstword completion option

2018-06-12 Thread Chet Ramey
On 6/12/18 1:28 PM, Luca Boccassi wrote: > On Fri, 2018-06-08 at 11:03 -0400, Chet Ramey wrote: >> On 6/8/18 10:40 AM, Luca Boccassi wrote: >> >>> Any chance you had a sec to look at the diff? Would love some >>> feedback! >> >> I'm going to try and look at it this weekend. It's been a busy couple

Re: [PATCH] Add nofirstword completion option

2018-06-12 Thread Luca Boccassi
On Fri, 2018-06-08 at 11:03 -0400, Chet Ramey wrote: > On 6/8/18 10:40 AM, Luca Boccassi wrote: > > > Any chance you had a sec to look at the diff? Would love some > > feedback! > > I'm going to try and look at it this weekend. It's been a busy couple > of > months. Hi Chet, I've seen that the

Re: [PATCH] Add nofirstword completion option

2018-06-08 Thread Chet Ramey
On 6/8/18 10:40 AM, Luca Boccassi wrote: > Any chance you had a sec to look at the diff? Would love some feedback! I'm going to try and look at it this weekend. It's been a busy couple of months. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita b

Re: [PATCH] Add nofirstword completion option

2018-06-08 Thread Luca Boccassi
On Fri, 2018-06-01 at 14:40 +0100, Luca Boccassi wrote: > On Tue, 2018-05-29 at 15:44 +0100, Luca Boccassi wrote: > > On Fri, 2018-05-25 at 14:40 -0400, Chet Ramey wrote: > > > On 5/25/18 1:42 PM, Luca Boccassi wrote: > > > > > > > > There is already logic that determines whether the shell is > >

Re: [PATCH] Add nofirstword completion option

2018-06-01 Thread Luca Boccassi
On Tue, 2018-05-29 at 15:44 +0100, Luca Boccassi wrote: > On Fri, 2018-05-25 at 14:40 -0400, Chet Ramey wrote: > > On 5/25/18 1:42 PM, Luca Boccassi wrote: > > > > > > There is already logic that determines whether the shell is > > > > trying to > > > > complete a command word (in_command_position

Re: [PATCH] Add nofirstword completion option

2018-05-29 Thread Luca Boccassi
On Fri, 2018-05-25 at 14:40 -0400, Chet Ramey wrote: > On 5/25/18 1:42 PM, Luca Boccassi wrote: > > > > There is already logic that determines whether the shell is > > > trying to > > > complete a command word (in_command_position). The existing code > > > does > > > not attempt programmable compl

Re: [PATCH] Add nofirstword completion option

2018-05-25 Thread Chet Ramey
On 5/25/18 1:42 PM, Luca Boccassi wrote: >> There is already logic that determines whether the shell is trying to >> complete a command word (in_command_position). The existing code does >> not attempt programmable completion if in_command_position == 1. The >> additional functionality would: >> >

Re: [PATCH] Add nofirstword completion option

2018-05-25 Thread Luca Boccassi
On Wed, 2018-05-23 at 09:53 -0400, Chet Ramey wrote: > On 5/23/18 9:34 AM, Luca Boccassi wrote: > > On Wed, 2018-05-23 at 09:15 -0400, Chet Ramey wrote: > > > On 5/23/18 5:44 AM, Luca Boccassi wrote: > > > > > > > So by that, do you mean that it's possible to stop > > > > autocompleting > > > > to

Re: [PATCH] Add nofirstword completion option

2018-05-23 Thread Chet Ramey
On 5/23/18 9:34 AM, Luca Boccassi wrote: > On Wed, 2018-05-23 at 09:15 -0400, Chet Ramey wrote: >> On 5/23/18 5:44 AM, Luca Boccassi wrote: >> >>> So by that, do you mean that it's possible to stop autocompleting >>> to >>> files/dirs/binaries just using a programmable completion script? Or >>> did

Re: [PATCH] Add nofirstword completion option

2018-05-23 Thread Luca Boccassi
On Wed, 2018-05-23 at 09:15 -0400, Chet Ramey wrote: > On 5/23/18 5:44 AM, Luca Boccassi wrote: > > > So by that, do you mean that it's possible to stop autocompleting > > to > > files/dirs/binaries just using a programmable completion script? Or > > did > > I misunderstand? Apologies if that's th

Re: [PATCH] Add nofirstword completion option

2018-05-23 Thread Chet Ramey
On 5/23/18 5:44 AM, Luca Boccassi wrote: > So by that, do you mean that it's possible to stop autocompleting to > files/dirs/binaries just using a programmable completion script? Or did > I misunderstand? Apologies if that's the case. > > Right now we do have completion scripts to implement the h

Re: [PATCH] Add nofirstword completion option

2018-05-23 Thread Luca Boccassi
On Sun, 2018-05-20 at 15:34 -0400, Chet Ramey wrote: > On 5/18/18 7:06 AM, Luca Boccassi wrote: > > Network operating systems traditionally have provided a command > > line interface with "operation mode" and "configuration mode", with > > different auto-completion behaviour - specifically, with a

Re: [PATCH] Add nofirstword completion option

2018-05-20 Thread Chet Ramey
On 5/18/18 7:06 AM, Luca Boccassi wrote: > Network operating systems traditionally have provided a command > line interface with "operation mode" and "configuration mode", with > different auto-completion behaviour - specifically, with a small set > of supported commands that are printed using the

[PATCH] Add nofirstword completion option

2018-05-18 Thread Luca Boccassi
Network operating systems traditionally have provided a command line interface with "operation mode" and "configuration mode", with different auto-completion behaviour - specifically, with a small set of supported commands that are printed using the auto-completion shortcut key, depending on the mo