Re: bash: Correct usage of F_SETFD

2010-11-23 Thread Sukadev Bhattiprolu
Eric Blake [ebl...@redhat.com] wrote: | > | > So if bash is the one creating its file descriptors, there's no need to | > use R/M/W since it knows what the state of them are. | | No, bash cannot reasonably know what the implementation's default bit | state is, and blindly setting all other bits t

Re: bash: Correct usage of F_SETFD

2010-11-22 Thread Sukadev Bhattiprolu
Eric Blake [ebl...@redhat.com] wrote: | On 11/22/2010 03:16 PM, Chet Ramey wrote: | >> include/filecntl.h in bash-4.1 has following: | >> | >> #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) | >> | >> Is that really the correct/intended usage of F_SETFD ? | > | > F_SETFD

bash: Correct usage of F_SETFD

2010-11-22 Thread Sukadev Bhattiprolu
include/filecntl.h in bash-4.1 has following: #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) Is that really the correct/intended usage of F_SETFD ? If kernel ever adds a new flag to the fd, this would end up clearing the other new flag right ? Shouldn't bash use F_GETFD to