Re: [PATCH] Fix custom program's completions when initial word is set

2018-11-26 Thread Luca Boccassi
On Sun, 2018-11-25 at 23:04 +1300, Tom Ryder wrote: > On Fri, Nov 23, 2018 at 12:48:54PM +0000, Luca Boccassi wrote: > > The fix is to only override foundcs if both iw_compspec is not null > > and we are not in command position. > > Thank you for this patch. I first ran in

[PATCH] Fix custom program's completions when initial word is set

2018-11-23 Thread Luca Boccassi
The change to fix mid-word initial completion inadvertently broke custom command completion. To reproduce: cat > repro< --- Dear Maintainer, noticed this a bit too late after some more testing. This fix appears to work, let me know if you'd like a different solution. Thanks! bashline.c | 2 +-

[PATCH] initial word completion: fix completion of prefix

2018-11-09 Thread Luca Boccassi
If the user types: gcfile.c And positions the cursor of 'f', a programmable completion enabled on initial word (-I) will fail to run. This is because the parsing gives priority first to the _minimal programmable completion that does nothing, and then if that is disabled it gives the next priority

Re: [PATCH] Add nofirstword completion option

2018-06-19 Thread Luca Boccassi
On Tue, 2018-06-12 at 15:18 -0400, Chet Ramey wrote: > On 6/12/18 3:15 PM, Luca Boccassi wrote: > > > In case it can be somewhat useful, once 5.0-beta with the new > > option is > > out I'll ask QA at $work to run regressions tests on it and report > > back >

Re: [PATCH] Add nofirstword completion option

2018-06-12 Thread Luca Boccassi
On Tue, 2018-06-12 at 14:54 -0400, Chet Ramey wrote: > On 6/12/18 1:28 PM, Luca Boccassi wrote: > > On Fri, 2018-06-08 at 11:03 -0400, Chet Ramey wrote: > > > On 6/8/18 10:40 AM, Luca Boccassi wrote: > > > > > > > Any chance you had a sec to look at the

Re: [PATCH] Add nofirstword completion option

2018-06-12 Thread Luca Boccassi
On Fri, 2018-06-08 at 11:03 -0400, Chet Ramey wrote: > On 6/8/18 10:40 AM, Luca Boccassi wrote: > > > Any chance you had a sec to look at the diff? Would love some > > feedback! > > I'm going to try and look at it this weekend. It's been a busy couple > of &g

Re: [PATCH] Add nofirstword completion option

2018-06-08 Thread Luca Boccassi
On Fri, 2018-06-01 at 14:40 +0100, Luca Boccassi wrote: > On Tue, 2018-05-29 at 15:44 +0100, Luca Boccassi wrote: > > On Fri, 2018-05-25 at 14:40 -0400, Chet Ramey wrote: > > > On 5/25/18 1:42 PM, Luca Boccassi wrote: > > > > > > > > There is already

Re: [PATCH] Add nofirstword completion option

2018-06-01 Thread Luca Boccassi
On Tue, 2018-05-29 at 15:44 +0100, Luca Boccassi wrote: > On Fri, 2018-05-25 at 14:40 -0400, Chet Ramey wrote: > > On 5/25/18 1:42 PM, Luca Boccassi wrote: > > > > > > There is already logic that determines whether the shell is > > > > tr

Re: [PATCH] Add nofirstword completion option

2018-05-29 Thread Luca Boccassi
On Fri, 2018-05-25 at 14:40 -0400, Chet Ramey wrote: > On 5/25/18 1:42 PM, Luca Boccassi wrote: > > > > There is already logic that determines whether the shell is > > > trying to > > > complete a command word (in_command_position). The existing code > >

Re: [PATCH] Add nofirstword completion option

2018-05-25 Thread Luca Boccassi
On Wed, 2018-05-23 at 09:53 -0400, Chet Ramey wrote: > On 5/23/18 9:34 AM, Luca Boccassi wrote: > > On Wed, 2018-05-23 at 09:15 -0400, Chet Ramey wrote: > > > On 5/23/18 5:44 AM, Luca Boccassi wrote: > > > > > > > So by that, do you mean that it&#x

Re: [PATCH] Add nofirstword completion option

2018-05-23 Thread Luca Boccassi
On Wed, 2018-05-23 at 09:15 -0400, Chet Ramey wrote: > On 5/23/18 5:44 AM, Luca Boccassi wrote: > > > So by that, do you mean that it's possible to stop autocompleting > > to > > files/dirs/binaries just using a programmable completion script? Or > > did >

Re: [PATCH] Add nofirstword completion option

2018-05-23 Thread Luca Boccassi
On Sun, 2018-05-20 at 15:34 -0400, Chet Ramey wrote: > On 5/18/18 7:06 AM, Luca Boccassi wrote: > > Network operating systems traditionally have provided a command > > line interface with "operation mode" and "configuration mode", with > > different auto-co

[PATCH] Add shopt to enable writing history to syslog at runtime

2018-05-18 Thread Luca Boccassi
ility keep using SYSLOG_HISTORY as before to enable logging to syslog unconditionally. Signed-off-by: Luca Boccassi --- bashhist.c | 27 +++ builtins/shopt.def | 11 +++ doc/bash.0 | 3 +++ doc/bash.1 | 5 + doc/bash.html | 6 +

[PATCH] Add nofirstword completion option

2018-05-18 Thread Luca Boccassi
nd document a nofirstword completion option to implement this feature. Signed-off-by: Luca Boccassi --- bashline.c| 47 +++ builtins/complete.def | 4 doc/bash.1| 4 doc/bash.html | 5 + doc/bash.inf