Re: [PATCH] Makefile: avoid undefined variables

2024-10-25 Thread Dmitry Goncharov
>- cd $(@D) && $(MAKE) BUILD_DIR=$(UP)$(BUILD_DIR) >top_srcdir=$(UPSRC)$(top_srcdir) $(MAKEFLAGS) $(@F) It is really not a good idea to pass makeflags on the command line as a positional parameter. A variable (any variable, including makeflags) set on the command line, overrides the value

Re: bash parallel build: make[1]: warning: -j16 forced in submake: resetting jobserver mode.

2024-04-13 Thread Dmitry Goncharov
On Sat, Apr 13, 2024 at 12:41 AM Cedric Blancher wrote: > > Good morning! > > Building bash HEAD on Cygwin 3.5.3 and Debian Linux 11 in make > parallel mode issues a warning, which looks like a Makefile bug: > $ make -h 16 > ... > make[1]: warning: -j16 forced in submake: resetting jobserver mode

Re: Bash Coding style - Adopting C99 declarations

2022-08-28 Thread Dmitry Goncharov
On Sunday, August 28, 2022, Andreas Schwab wrote: > On Aug 28 2022, Greg Wooledge wrote: > > > On Sun, Aug 28, 2022 at 10:47:38AM -0400, Yair Lenga wrote: > >> Hi, > >> > >> I've noticed Bash code uses "old-style" C89 declarations: > >> * Parameters are separated from the prototype > >> * Variabl

Re: Misleading error when attempting to run foreign executable

2021-10-10 Thread Dmitry Goncharov via Bug reports for the GNU Bourne Again SHell
On Sun, Oct 10, 2021 at 9:11 PM Eli Schwartz wrote: > So I wonder, if bash already in this exact case attempts to open() the > file and read() it to look for a shebang, what's the harm in assuming > (or checking) that it exists in this patch? i guess, you are right. i, on the other hand wonder, i

Re: Misleading error when attempting to run foreign executable

2021-10-10 Thread Dmitry Goncharov via Bug reports for the GNU Bourne Again SHell
On Sun, Oct 10, 2021 at 7:52 PM Ángel wrote: > Looking at the code, it doesn't even need an extra stat(), it already > knows the file exists Attempts to know ahead of time or check afterwards that the file exists are subject to a race condition. regards, Dmitry

Re: GROUPS

2021-08-10 Thread Dmitry Goncharov via Bug reports for the GNU Bourne Again SHell
On Tue, Aug 10, 2021 at 8:57 PM Franklin, Jason wrote: > What surprised me was that Bash-specific "magic" variables did not lose > their "magic" qualities when Bash was invoked in a POSIX-compliant mode > of execution. Posix mode does not mean that bash-specific variables (or anything else bash-s

Re: Document that set -v inside case statements is special

2021-04-20 Thread Dmitry Goncharov via Bug reports for the GNU Bourne Again SHell
On Tue, Apr 20, 2021 at 2:37 PM Greg Wooledge wrote: > With case, or any other compound command, the entire compound command is > read from the script and parsed, before bash can start running it. So, by > the time the set -v is executed, the entire case command has already been > read. Is not

Re: Is this a bug?

2020-08-18 Thread Dmitry Goncharov via Bug reports for the GNU Bourne Again SHell
On Tue, Aug 18, 2020 at 7:57 PM George R Goffe wrote: > > Chet, > > Thanks for your response. > > I'm running konsoles (KDE). I have tried complettion but don't see any > evidence of bell ringing. Not even a flash. > > Do you think that bash have a problem with konsole? Maybe it's a konsole bug?

Re: Is this a bug?

2020-08-06 Thread Dmitry Goncharov via Bug reports for the GNU Bourne Again SHell
On Thu, Aug 6, 2020 at 1:54 PM George R Goffe wrote: > I have several directories on a system with > 300k files. When I use filename > completion bash freezes for over a minute depending on the number of files. > I'm pretty sure that bash has to read the directory to do the completion but > the

Re: Incorrect example for `[[` command.

2019-09-21 Thread Dmitry Goncharov via Bug reports for the GNU Bourne Again SHell
On Sat, Sep 21, 2019 at 12:34:39PM +0300, Ilkka Virta wrote: > [[:space:]]*?(a)b isn't a well-defined POSIX ERE: > >9.4.6 EREs Matching Multiple Characters > >The behavior of multiple adjacent duplication symbols ( '+', '*', '?', >and intervals) produces undefined results. > > https

Re: Subshell exit trap is not invoked if shell exit trap also set

2019-03-26 Thread Dmitry Goncharov
On Mon, Mar 25, 2019 at 6:24 PM Konstantin Andreev wrote: > Verified on: > > Solaris 11.3, bash 4.1.17(1)-release (i386-pc-solaris2.11) > CentOS Linux 7.2.1511, bash 4.2.46(1)-release (x86_64-redhat-linux-gnu) > CentOS Linux 7.2.1511, bash 5.0.0(1)-release (x86_64-pc-linux-gnu) Dou

Re: ``read -N n -t timeout'' saves partial input only when EOF is seen?

2016-11-25 Thread Dmitry Goncharov
Auto variables have unspecified values after a call to longjmp. This patch fixes the bug. regards, Dmitry diff --git a/builtins/read.def b/builtins/read.def index 5e2348c..938b62a 100644 --- a/builtins/read.def +++ b/builtins/read.def @@ -181,7 +181,8 @@ read_builtin (list) WORD_LIST *list;

Patch to fix a leak in split_at_delims.

2016-08-23 Thread Dmitry Goncharov
regards, Dmitry diff --git a/subst.c b/subst.c index 673376b..09fc915 100644 --- a/subst.c +++ b/subst.c @@ -2019,8 +2019,10 @@ split_at_delims (string, slen, delims, sentinel, flags, nwp, cwp) long as those characters are delimiters. */ for (i = 0; member (string[i], d) && spctabnl (stri

Patch to fix a memory leak in pat_subst

2016-08-23 Thread Dmitry Goncharov
Good morning. This patch fixes a leak in pat_subst. regards, Dmitry diff --git a/subst.c b/subst.c index 3958237..673376b 100644 --- a/subst.c +++ b/subst.c @@ -6682,6 +6682,7 @@ pat_subst (string, pat, rep, mflags) mstr[x] = s[x]; mstr[mlen] = '\0'; rstr = strcr

Re: a patch to fix sh_stat on SunOS

2016-08-21 Thread Dmitry Goncharov
On Sun, Aug 21, 2016 at 03:04:07PM -0400, Chet Ramey wrote: > The current text in redirection says: > > Bash handles several filenames specially when they are used in redirec- >tions, as described in the following table. If the operating system on >which bash is running provides t

Re: a patch to fix sh_stat on SunOS

2016-08-21 Thread Dmitry Goncharov
On Sun, Aug 21, 2016 at 04:03:05PM -0400, Grisha Levit wrote: > On Aug 20, 2016 9:32 PM, "Dmitry Goncharov" wrote: > > With this new contract how can the user write portable bash code which > tests if a fd refers to a pipe? > > The test command seems to have the behav

Patch to fix braces test

2016-08-21 Thread Dmitry Goncharov
Good morning. The patch in the attachment fixes the test in braces.c. Repace free_array with strvec_dispose. Remove unused fatal_error and report_error to eliminate linking failures. regards, Dmitry diff --git a/braces.c b/braces.c index c6d567f..4e66fb3 100644 --- a/braces.c +++ b/braces.c @@ -

Patch to fix a leak in expand_amble.

2016-08-21 Thread Dmitry Goncharov
Good morning. The patch in the attachment fixes a leak in expand_amble. regards, Dmitry diff --git a/braces.c b/braces.c index 61c1ab1..c6d567f 100644 --- a/braces.c +++ b/braces.c @@ -319,6 +319,8 @@ expand_amble (text, tlen, flags) if (tresult == 0) { interna

fix a memory leak in netopen

2016-08-20 Thread Dmitry Goncharov
Good morning. The patch in the attachment fixes a memory leak in netopen. regards, Dmitry diff --git a/lib/sh/netopen.c b/lib/sh/netopen.c index 736d413..e584548 100644 --- a/lib/sh/netopen.c +++ b/lib/sh/netopen.c @@ -304,6 +304,7 @@ netopen (path) if (t == 0) { internal_error (_

Re: a patch to fix sh_stat on SunOS

2016-08-20 Thread Dmitry Goncharov
On Thu, Aug 11, 2016 at 07:52:51AM -0400, Chet Ramey wrote: > On 8/10/16 5:38 PM, Dmitry Goncharov wrote: > > >> > does "If any file argument to one of the primaries is of the form > > > >> > /dev/fd/n, then file descriptor n is checked.". >

Re: a patch to fix sh_stat on SunOS

2016-08-10 Thread Dmitry Goncharov
On Wed, Aug 10, 2016 at 10:30 AM, Chet Ramey wrote: > > On 8/10/16 10:19 AM, Dmitry Goncharov wrote: > > > bash does not do what the following quote from the bash man page says it > > > does "If any file argument to one of the primaries is of the form > >

Re: a patch to fix sh_stat on SunOS

2016-08-10 Thread Dmitry Goncharov
On Wed, Aug 10, 2016 at 9:56 AM, Chet Ramey wrote: > So what you're saying is that you don't like how SunOS implements /dev/fd > > and you'd like bash to override the native implementation semantics. i don't care how sunos implements /dev/fd. i care that bash fails on sunos. bash does not do wh

a patch to fix sh_stat on SunOS

2016-08-10 Thread Dmitry Goncharov
Good morning, The following piece of shell code does not work on sunos. mkfifo /tmp/pipe cat < /tmp/pipe & exec 6>/tmp/pipe test -p /dev/fd/6 && echo pipe The reason is on sunos /dev/fd/6 is a special character file, not a pipe (unlike bsd), not a symlink (unlike linux, cygwin). sh_stat ends up c