Re: Missing semicolon tolerated after double-bracket [[ ]] expression

2025-09-15 Thread Collin Funk
Andreas Schwab writes: > On Sep 15 2025, Chet Ramey wrote: > >> On 9/13/25 10:55 AM, Lawrence Velázquez wrote: >> >>> Yeah, I misunderstood how locale_setblanks [1] works. Its function >>> comment is: >>> Set every character in the character class to be a >>> shell break character for t

Re: On Martin D. Kealey

2025-09-10 Thread Collin Funk
Chet Ramey writes: > In the years since publishing the work Martin cited, Eric Raymond has > undergone a radical personal transformation. He has adopted -- or > revealed -- some genuinely repugnant views. Google "eric raymond race iq" > for a taste. Or look at @esrtweet on twitter for something

Re: Project management in Savannah

2025-09-09 Thread Collin Funk
"G. Branden Robinson" writes: >> Questions are what qualifies a person to become the group member and >> what level of the responsibilities is expected from the group members. > > I can't answer this for Chet/bash, but for groff, commit privileges > attach to this status--I believe it's how I got

Re: Time to retire archaic mis-use of grave accent as opening single quote?

2025-09-01 Thread Collin Funk
Hi Chet, Chet Ramey writes: >> On Sun, 24 Aug 2025 at 16:59, G. Branden Robinson < >> g.branden.robin...@gmail.com> wrote: >> >>> I decline to address how Chet maintains plain text files in >>> his distribution. >>> >> Well that just side-steps basically everything that triggered me to >> write

Re: Time to retire archaic mis-use of grave accent as opening single quote?

2025-08-23 Thread Collin Funk
Hi Sam, Sam James writes: >> GNU is the last serious hold-out, and "this is how we've always done it" >> won't wash any more. > > It is, in fact, not the last serious hold-out at all: > https://www.gnu.org/prep/standards/standards.html#Quote-Characters. > > I don't recall when it changed other t

Re: Time to retire archaic mis-use of grave accent as opening single quote?

2025-08-23 Thread Collin Funk
Martin D Kealey writes: > I note that much of the documentation still uses a quoting style that > pretends that characters U+0060 and U+0027 are matching opening and closing > quotes, and that new documentation is still being added that follows this > style. For extra credit, they're sometimes re

Re: [PATCH] _rl_isearch_cleanup: avoid nested execution

2025-08-20 Thread Collin Funk
Chet Ramey writes: >> ./parse.y:501.23-27: symbol YYEOF is used, but is not defined as a >> token and has no rules > > This means your bison is too old. configure should have told you. This is a common MacOS issue. Since Apple is allergic to GPLv3+. See: $ /usr/bin/bison --version bison

Re: autoconf broken when forcing -Werror -pedantic

2025-07-07 Thread Collin Funk
Martin D Kealey writes: >> Martin D Kealey writes: >> > it's SLOW. > > > Any comments on this point? > > It seems like the main causes of inadequate speed are: > (1) Lack of parallelism. > (2) A monolithic probe-test-result cache structure, that's either "all > valid" or "all discarded". Sure,

Re: autoconf broken when forcing -Werror -pedantic

2025-07-06 Thread Collin Funk
Martin D Kealey writes: > > At this point I'm beginning to question the value of autoconf for "general > use". I'm sure it's still useful for corner cases, but it was conceived for > a different world, and assumptions made back then have become problems now. > > And it's SLOW. On my fairly old com

Re: [PATCH] Fix link error on GNU/Hurd.

2025-05-16 Thread Collin Funk
Hi Chet, Chet Ramey writes: > Thanks for the report. I'm interested in why you're not using ncurses. Is > it just not installed on your build system? I occasionally test Gnulib in a Hurd VM (fresh each time since my image doesn't like to reboot, unfortunately). I had assumed that libncurses-de

[PATCH] Fix link error on GNU/Hurd.

2025-05-08 Thread Collin Funk
/terminal.c:109: first defined here I have attached a patch which fixes it. The issue is very simple, just a missing '#if defined'. Collin >From 253559a51dda6c15afbae3174b7b887dede7d9e3 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Thu, 8 May 2025 22:21:15 -0700 Subject: [PATCH

Re: Is this a bug?

2025-03-23 Thread Collin Funk
Hi, George R Goffe writes: > I've been trying to build bash from a repository > "https://git.savannah.gnu.org/git/bash.git"; and a having the devil's own time > in the process. > > Did I just catch the repository in the middle of a rework? I have a > full log of the build process if it's neede

Re: Out of bounds read in parse.y.

2024-08-28 Thread Collin Funk
Chet Ramey writes: > Thanks. Here's the simple reproducer: > > x() > { > case y in > z) > if (! false); then > foo=bar > fi > ;; > esac > } > > > It was what I suspected. Ah, nice! Thank you for the help. Collin

Re: Out of bounds read in parse.y.

2024-08-27 Thread Collin Funk
Hi Chet, Chet Ramey writes: > Which version? This was from bash devel branch, commit hash 2e01122fe78eb5a42c9b9f3ca46b91f895959675. Built with: ./configure CFLAGS='-fsanitize=undefined' > Why? 0 is a valid index. set_word_top increments word_top before assigning > to word_lineno[word_top

Out of bounds read in parse.y.

2024-08-26 Thread Collin Funk
Hi, When compiling with undefined behavior sanitizer and then running: $ ./bash parse.y:1000:93: runtime error: index -1 out of bounds for type 'int [257]' The offending section of code: case_command: CASE WORD newline_list IN newline_list ESAC {

Re: [PATCH] malloc: fix out-of-bounds read

2024-07-22 Thread Collin Funk
Hi Chet, Chet Ramey writes: >> /* Use this when we want to be sure that NB is in bucket NU. */ >> #define RIGHT_BUCKET(nb, nu) \ >> (((nb) > binsizes[(nu)-1]) && ((nb) <= binsizes[(nu)])) > > The right fix here is two-fold: fix the first test here to evaluate to 0 > if nu == 0, and change t

[PATCH] malloc: fix out-of-bounds read

2024-07-18 Thread Collin Funk
an atleast. I didn't look into the surrounding code much so a double check would be nice. :) Collin >From 4863afd5260e11f05f69adc64c496f6d8bace627 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Thu, 18 Jul 2024 21:45:51 -0700 Subject: [PATCH] malloc: fix out-of-bounds read * lib/ma

Re: printf %m$ and %*m$ unimplemented in Bash, but implementated in C compilers

2024-05-27 Thread Collin Funk
porterleete writes: > Fix: > Either update the documentation of what printf in bash actually does. > If printf is using a standard for printf other than "what the biggest > C compilers currently do", document which standard it's using or > update it to the newest standard used by gcc and clang.

Incorrect string length check

2024-05-23 Thread Collin Funk
Hi Chet, In this commit in the devel branch: commit 03c8c43b79177fa678714893e9f05b1c517592c0 Author: Chet Ramey Date: Fri Apr 5 09:03:52 2024 -0400 man page typesetting updates for compatibilityand layout issues I think there was a typo in execute_cmd.c: diff --git a/execute_cmd.c b/exe

Re: build failure without system extension macros

2024-05-16 Thread Collin Funk
Hi Chet, On 5/16/24 7:25 AM, Chet Ramey wrote: > Yes. This was inspired by > > https://lists.gnu.org/archive/html/bug-bash/2024-04/msg00158.html I'm not sure if you have dealt with this particular one yet, but I would just get rid of the u_char, u_short, u_long, types. They are old BSD stuff tha

Re: [PATCH] Fix minor portability issues including ISO C 23 prototypes.

2024-02-14 Thread Collin Funk
On 2/14/24 11:56 AM, Chet Ramey wrote: > This isn't necessary in general; ISO C guarantees that a constant > expression with value 0 is a null pointer constant just like NULL, > and the compiler will make them equivalent even if the internal > representation of a null pointer isn't all zeroes. Oop

[PATCH] Fix minor portability issues including ISO C 23 prototypes.

2024-02-13 Thread Collin Funk
Hi, I noticed some compiler warnings that might be worth fixing. I wasn't sure if patches should have ChangeLog entries so I left it alone and tried to make it easy to copy paste for you. Feel free to use or ignore changes as you see fit. Thanks, Collin * lib/malloc/malloc.c (botch): Add correct