Re: address XXX comment at lines 987-990 in bashfile.c

2015-07-11 Thread Bill Parker
ul 10, 2015 at 11:30 PM, Eduardo A. Bustamante López < dual...@gmail.com> wrote: > On Thu, Jul 09, 2015 at 01:53:52PM -0700, Bill Parker wrote: > > Hello All, > > > >In reviewing the code at line 990 in bashfile.c, while the > > issue of rl_line_buffer[0] = &

address XXX comment at lines 987-990 in bashfile.c

2015-07-09 Thread Bill Parker
1] is: As you can see, setting buffer[0] to '\0' doesn't exactly clobber the remaining data in buffer, but after calling memset(), all of the data is clobbered. Comments, Questions, Suggestions, Complaints? :) I am attaching the patch file to this bug report. Bill Parker (wp02855 at gmail dot com) bashline.c.patch Description: Binary data

missing sanity checks for malloc() in bash-4.3.3x in directory 'support', file 'man2html.c'

2015-07-08 Thread Bill Parker
de = (STRDEF *) malloc(sizeof(STRDEF)); + if (de == NULL) { + fprintf(stderr, "man2html: out of memory in scan_request()"); + exit(EXIT_FAILURE); + } de->nr = i; de->next = defdef; de->st = h; Comments, Questions, Suggestions, etc? I am attaching the patch file to this bug report. Bill Parker (wp02855 at gmail dot com) man2html.c.patch Description: Binary data