Re: [PATCH] confusing/obsolete handling of test -t operator (and doc warnings against using -o/-a)

2023-07-10 Thread Chet Ramey
On 7/8/23 3:18 AM, Stephane Chazelas wrote: 2023-07-07 15:52:28 -0400, Chet Ramey: [...] Historical versions of test made the argument to -t optional here. I can continue to support that in default mode for backwards compatibility, but it will be an error in posix mode. [...] I think you may h

Re: leak in command_word_completion_function

2023-07-10 Thread Chet Ramey
On 7/7/23 5:35 PM, Grisha Levit wrote: If there a glob is expanded to more than one result while attempting to complete the command word, the matches are discarded but not freed. Thanks for the report. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa,

Re: give_terminal_to after re-backgrounded async job

2023-07-10 Thread Chet Ramey
On 7/7/23 12:43 PM, Grisha Levit wrote: The fix [1] for the issue reported in [2]: + give the terminal to pipeline_pgrp. We don't give the terminal + back to shell_pgrp if an async job exits because we never gave it + to that job in the first place. */ if ((flags & JWAIT_NOTERM) == 0 &&