Re: coding standards

2018-03-05 Thread don fong
Clark, Just took a look at the code and it is an int: declaring boolean quantities as int is a common practice in old C code. indeed, all the boolean vars in this program seem to be declared as int. at least, i don't see anything declared as bool. declared type notwithstanding, in the context o

Re: add generated files to .gitignore

2018-03-05 Thread Mike Frysinger
On 05 Mar 2018 14:33, Chet Ramey wrote: > On 3/5/18 1:15 PM, Mike Frysinger wrote: > > On 02 Mar 2018 14:25, Chet Ramey wrote: > >> On 2/27/18 11:46 AM, don fong wrote: > >>> Chet, thanks for the suggestion. > >>> > >>> i still wonder what's the objection to changing .gitignore? > >> > >> I don't t

Re: add generated files to .gitignore

2018-03-05 Thread Chet Ramey
On 3/5/18 1:15 PM, Mike Frysinger wrote: > On 02 Mar 2018 14:25, Chet Ramey wrote: >> On 2/27/18 11:46 AM, don fong wrote: >>> Chet, thanks for the suggestion. >>> >>> i still wonder what's the objection to changing .gitignore? >> >> I don't think it will be useful to me, since I curate the commits

Re: add generated files to .gitignore

2018-03-05 Thread Mike Frysinger
On 02 Mar 2018 14:25, Chet Ramey wrote: > On 2/27/18 11:46 AM, don fong wrote: > > Chet, thanks for the suggestion. > > > > i still wonder what's the objection to changing .gitignore? > > I don't think it will be useful to me, since I curate the commits I > make to the various branches, but I don

Re: [off-topic] ksh local vars [was: Unset array doesn't work]

2018-03-05 Thread Koichi Murase
2018-03-05 22:57 GMT+09:00 Greg Wooledge : > On Sat, Mar 03, 2018 at 08:24:06PM +0900, Koichi Murase wrote: >> - Note: ksh seems not support local variables. "typeset" in function >> scopes defines a global variable, and "unset" removes the global >> variable. > > "Real ksh" has two different kinds

Re: unexpected behavior with read

2018-03-05 Thread Greg Wooledge
On Sun, Mar 04, 2018 at 06:15:05PM -0500, Zach Hadgraft wrote: > Description: > global variable assignments fail when part of a sequence that > includes read and begins with a function invoked by command substitution > read can be invoked by another function, or invoked by another >

[off-topic] ksh local vars [was: Unset array doesn't work]

2018-03-05 Thread Martijn Dekker
Op 05-03-18 om 13:57 schreef Greg Wooledge: > On Sat, Mar 03, 2018 at 08:24:06PM +0900, Koichi Murase wrote: >> - Note: ksh seems not support local variables. "typeset" in function >> scopes defines a global variable, and "unset" removes the global >> variable. > > "Real ksh" has two different kin

Re: Unset array doesn't work

2018-03-05 Thread Greg Wooledge
On Sat, Mar 03, 2018 at 08:24:06PM +0900, Koichi Murase wrote: > - Note: ksh seems not support local variables. "typeset" in function > scopes defines a global variable, and "unset" removes the global > variable. "Real ksh" has two different kinds of functions -- ones declared with "foo()" and one