Re: [PATCH] Fix hang if $OLDPWD points to inaccessible directory

2017-11-28 Thread Chet Ramey
On 11/27/17 4:00 PM, Mikulas Patocka wrote: > Will you commit my patch? - if you agree with it. I believe it's a good idea to restrict importing values of OLDPWD to directories, but I will provide a configuration option (config-top.h for now) to optionally disable it. Chet -- ``The lyf so shor

Re: Bash: sleep execution issue with bash loadable builtins

2017-11-28 Thread Chet Ramey
On 11/28/17 9:41 AM, Chet Ramey wrote: > On 11/27/17 2:47 PM, Ángel wrote: > >> Also there's the issue that select() _may_ modify the object pointed to >> by the timeout argument [POSIX]. But it may not, in which case this >> would end up oversleeping. >> >> On such system, doing eg. >> sleep 9 &

Re: Bash: sleep execution issue with bash loadable builtins

2017-11-28 Thread Chet Ramey
On 11/27/17 2:47 PM, Ángel wrote: > Also there's the issue that select() _may_ modify the object pointed to > by the timeout argument [POSIX]. But it may not, in which case this > would end up oversleeping. > > On such system, doing eg. > sleep 9 & time sleep 10 > > would end up sleeping 19 sec

Re: Bash: sleep execution issue with bash loadable builtins

2017-11-28 Thread Chet Ramey
On 11/28/17 12:17 AM, Thiruvadi Rajaraman wrote: > Hi, > > Thanks a lot for your review comments. > > I have reworked on the bash sleep fix based on your suggestion about signal > and trap handling in fsleep( ). > > I have attached the fix patch for your kind reference. Your patch unconditional

Re: [PATCH] Fix hang if $OLDPWD points to inaccessible directory

2017-11-28 Thread Eduardo Bustamante
On Mon, Nov 27, 2017 at 6:00 PM, Mikulas Patocka wrote: [...] > Will you commit my patch? - if you agree with it. Hi Mikulas. Chet is the one and only bash maintainer, you'd have to convince him. As a bystander that happens to be interested in bash's development, I agree with your points, but ex

回复:[here string] uncompatible change on here string function

2017-11-28 Thread 尹剑虹
Thanks all. Now I got it: The point is the action on bash-4.2 and before deosn't match the action on ksh and zsh. Jianhong 发自网易邮箱手机版 在2017年11月27日 23:42,Vladimir Marek 写道: > > It's not the point. the problem is bash-4.4 auto add quote around $var or > > $(cmd) after '<<<' > > > > On bash-4.

Re: Bash: sleep execution issue with bash loadable builtins

2017-11-28 Thread Thiruvadi Rajaraman
Hi, Thanks a lot for your review comments. I have reworked on the bash sleep fix based on your suggestion about signal and trap handling in fsleep( ). I have attached the fix patch for your kind reference. Test logs with fix patch: == root@x86-generic-64:~/bash-4.2# ./bash root