4.4: crash in redir10 test; use after free?

2016-11-01 Thread Christian Weisgerber
Running the bash 4.4 regression test suite on OpenBSD/amd64, I noticed a crash in the redir tests. Specifically, running redir10.sub with bash 4.4 causes it to die with a bus error most of the time. Program terminated with signal 10, Bus error. #0 0x1c9ad0634009 in find_pipeline (pid=97028,

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-11-01 Thread Eric Blake
On 11/01/2016 10:41 AM, Tim Ruehsen wrote: >> >> Ouch. This version has O(n^2) complexity when dealing with deep >> hierarchies. GNU Coreutils intentionally prefers using >> openat()/fdopendir() and so on in order to recurse through the tree with >> O(n) complexity instead of O(n^2). > > As Che

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-11-01 Thread Chet Ramey
On 11/1/16 11:41 AM, Tim Ruehsen wrote: >>> if ((dir = opendir(dirname))) >>> >>> { >>> >>> while ((dp = readdir(dir))) >> >> Ouch. This version has O(n^2) complexity when dealing with deep >> hierarchies. GNU Coreutils intentionally prefers using >> openat()/fdopendir() and

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-11-01 Thread Tim Ruehsen
On Monday, October 31, 2016 4:44:21 PM CET Eric Blake wrote: > On 10/31/2016 04:14 PM, Chet Ramey wrote: > >> > Nice, thanks for the modifications. > > > > Here's the modified version. > > > > Chet > > -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars > > longa, vita brevis'' -

Re: 4.4 change in behavior from 4.3: how to catch unset when using ${#length}

2016-11-01 Thread Dan Douglas
On Mon, Oct 24, 2016 at 8:25 AM, Chet Ramey wrote: > On 10/21/16 5:41 PM, L. A. Walsh wrote: >> On 4.3 and earlier, at least on arrays, one could have >> the illusion of this working w/o complaint -- and returning >> 0 when the array was 0-len or unset, or the array length, >> otherwise: >> >> >>