Re: Out of bounds heap read in completion code detected when compiling bash with address sanitizer

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 6/23/15 3:22 PM, Hanno Böck wrote: > Btw, address sanitizer is just a compile feature of gcc and clang > activated by a cflag, you usually don't need anything special to have > it. Makes sense to test from time to time with it. I develop on Mac OS

Re: Out of bounds heap read in completion code detected when compiling bash with address sanitizer

On Tue, 23 Jun 2015 14:57:35 -0400 Chet Ramey wrote: > Thanks for the report. I don't have address sanitizer, but this was > pretty easy to find given what you provided. I've attached a patch > for folks to look at. Patch looks good, fixes the bug for me. Thanks a lot! Please drop me a note w

Re: Out of bounds heap read in completion code detected when compiling bash with address sanitizer

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 6/23/15 7:11 AM, Hanno Böck wrote: > Hello, > > When trying to compile latest bash (4.3 + all patches up to 039) with add ress sanitizer > I discovered a potential out of bounds read. > It seems to be related to tab completion and readline Thanks

Re: slow bgp_delete

> > The patch works nicely. However there were internal concerns that this > > change might cause some incompatibility to existing scripts. I would > > like to ask for your opinion on it. > > > > I am trying to come up with a scenario where this change might cause > > existing script to break. Thi

Re: slow bgp_delete

On 6/23/15 5:13 AM, Vladimir Marek wrote: > The patch works nicely. However there were internal concerns that this > change might cause some incompatibility to existing scripts. I would > like to ask for your opinion on it. > > I am trying to come up with a scenario where this change might cause

Out of bounds heap read in completion code detected when compiling bash with address sanitizer

Hello, When trying to compile latest bash (4.3 + all patches up to 039) with address sanitizer I discovered a potential out of bounds read. It seems to be related to tab completion and readline To reproduce: 1. compile bash with asan: ./configure --without-bash-malloc CFLAGS="-fsanitize=address

Re: slow bgp_delete

Hi Chet, ... > > a) decreasing size of the 'bgpids' list. Why do we need 30k entries if > > we don't trust that the IDs are unique? Maybe configuration or runtime > > option? > > I've thought about it. Posix only requires saving the statuses of the last > CHILD_MAX asynchronous pids. The bash