definite way to determine the running shell

2015-03-26 Thread Christoph Anton Mitterer
Hey. There are a lot of articles on the web about detecting the actually running shell. Unfortunately, just relying on $SHELL doesn't really work since when I invoke e.g. csh from bash, it would be still $SHELL=bash and I guess I won't be able to convince all shell upstreams to overwrite $SHELL (w

Re: feature-request: don't count history time comment lines when in HISTFILESIZE

2015-03-26 Thread Christoph Anton Mitterer
On Thu, 2015-03-26 at 16:54 -0400, Chet Ramey wrote: > The solution cannot be bash-specific; the history library is used by many > other applications. One, design-wise ugly, idea: Couldn't you abuse the history comment char another time for that? Like consider anything between a ^#[[:digit:]] to b

Re: feature-request: don't count history time comment lines when in HISTFILESIZE

2015-03-26 Thread Christoph Anton Mitterer
On Thu, 2015-03-26 at 15:21 -0400, Chet Ramey wrote: > What do you mean "ignore its effect"? You have newlines embedded in > history entries; what do you plan to do about them? Well that was just the uneducated idea based on blind assumptions by *not* having read the code O:-) AFAIU, both alread

Re: feature-request: don't count history time comment lines when in HISTFILESIZE

2015-03-26 Thread Christoph Anton Mitterer
On Thu, 2015-03-26 at 16:26 -0400, Chet Ramey wrote: > > And b) it seems kinda ugly that one needs to explicitly set a default > > value that would be set later anyway. > Maybe. Okay, keep me tuned if you should plan to actually do that, cause then I can revise manually setting it :) > It is wh

Re: feature-request: don't count history time comment lines when in HISTFILESIZE

2015-03-26 Thread Chet Ramey
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 3/26/15 4:51 PM, Eric Blake wrote: > On 03/26/2015 01:21 PM, Chet Ramey wrote: >> >> What do you mean "ignore its effect"? You have newlines embedded >> in history entries; what do you plan to do about them? > > Can't history lines be recorded as

Re: feature-request: don't count history time comment lines when in HISTFILESIZE

2015-03-26 Thread Eric Blake
On 03/26/2015 01:21 PM, Chet Ramey wrote: > > What do you mean "ignore its effect"? You have newlines embedded in > history entries; what do you plan to do about them? Can't history lines be recorded as $'...\n...' so as to be one line per command, even when the command contained newlines? --

Re: feature-request: don't count history time comment lines when in HISTFILESIZE

2015-03-26 Thread Chet Ramey
On 3/25/15 8:06 PM, Christoph Anton Mitterer wrote: > On Wed, 2015-03-25 at 16:19 -0400, Chet Ramey wrote: >> When you start bash, and source your .bashrc, the history comment character >> is not set. You haven't set it in .bashrc, I assume > Yes, I haven't. > >> Since that's not set, the lines b

Re: feature-request: don't count history time comment lines when in HISTFILESIZE

2015-03-26 Thread Chet Ramey
On 3/25/15 6:03 PM, Christoph Anton Mitterer wrote: > On Wed, 2015-03-25 at 16:21 -0400, Chet Ramey wrote: >> https://lists.gnu.org/archive/html/bug-bash/2011-02/msg00042.html > Maybe I've missed something but that thread basically just discussed the > same issue without giving a solution, right?