bug#7610: [PATCH] automake: support embedded \# in variable appends

2022-02-23 Thread Karl Berry
Agreed that it is better to preserve the input text. Agreed that a warning is indicated, but as Stefano suggested, I think the warning should only be given if -Wportability is enabled (which it is by default, I gather), not unconditionally. From our manual: `portability' Portab

bug#7610: [PATCH] automake: support embedded \# in variable appends

2022-02-20 Thread Mike Frysinger
On 20 Feb 2022 15:25, Karl Berry wrote: > Use of \# is not portable. > > Is there any known make implementation which does not preserve the #? > > foo = blah\#blah > foo += what > -> warning: escaping \# comment markers is not portable > -> foo = blah\#blah what > > A

bug#7610: [PATCH] automake: support embedded \# in variable appends

2022-02-20 Thread Karl Berry
Use of \# is not portable. Is there any known make implementation which does not preserve the #? foo = blah\#blah foo += what -> warning: escaping \# comment markers is not portable -> foo = blah\#blah what Assuming there is in fact variability in behavior in practice

bug#7610: [PATCH] automake: support embedded \# in variable appends

2022-02-20 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/7610. Use of \# is not portable. POSIX does not provide any way of retaining the # marker in variables. There is wide spread support for \# though in GNU & BSD Make implementations. Today, with plain variable assignments, Automake leaves the line alone: