bug#33573: Patch to replace symlinks with files

2023-01-01 Thread Sam James
> On 31 Dec 2022, at 19:20, Bogdan wrote: > > Karl Berry , Sat Dec 31 2022 03:30:42 GMT+0100 (Central > European Standard Time) > [snip] > >> For the same reason, it is good to explicitly cc a bug's originator and >> anyone else who has contributed to the bug, if you happen to have them. > >

bug#33573: Patch to replace symlinks with files

2023-01-01 Thread Karl Berry
FWIW, as a user I think this is the expected behavior. The option is named --add-missing, so if the file is not missing, I expect nothing to happen. I more or less agree, but the original suggestion from Ben (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33573) was for --add-missing

bug#33573: Patch to replace symlinks with files

2023-01-01 Thread Peter Johansson
Hi both, On 1/1/23 05:20, Bogdan wrote: Karl Berry , Sat Dec 31 2022 03:30:42 GMT+0100 (Central European Standard Time) Hi Bogdan, Someone reported a bug for this, so I simply gave it a try. Thank you! I didn't realize you were working on some of the old bugs. That is great! :) To

bug#33573: Patch to replace symlinks with files

2023-01-01 Thread Bogdan
Karl Berry , Sat Dec 31 2022 03:30:42 GMT+0100 (Central European Standard Time) Hi Bogdan, Someone reported a bug for this, so I simply gave it a try. Thank you! I didn't realize you were working on some of the old bugs. That is great! :) To bring this one in particular to fruition:

bug#33573: Patch to replace symlinks with files

2022-12-30 Thread Karl Berry
Hi Bogdan, Someone reported a bug for this, so I simply gave it a try. Thank you! I didn't realize you were working on some of the old bugs. That is great! To bring this one in particular to fruition: can you check what happens when -c -a would need to overwrite a symlink? I think it should

bug#33573: Patch to replace symlinks with files

2022-12-30 Thread Bogdan
Karl Berry , Fri Dec 30 2022 00:33:03 GMT+0100 (Central European Standard Time) Another simple patch from my side: when '--copy' given to '--add-missing', copy the standard files even if symlinks already exist. I am not sure about changing the behavior here. Although the behavior you p

bug#33573: Patch to replace symlinks with files

2022-12-29 Thread Karl Berry
Another simple patch from my side: when '--copy' given to '--add-missing', copy the standard files even if symlinks already exist. I am not sure about changing the behavior here. Although the behavior you propose is plausible, I fear that people might depend or expect on failure if symlin

bug#33573: Patch to replace symlinks with files

2022-12-29 Thread Bogdan
Hello, Automake gurus. Another simple patch from my side: when '--copy' given to '--add-missing', copy the standard files even if symlinks already exist. Basically, the patch adds "if --copy given and a link exists, do NOT exit" (+ a double-check of the object type if that would be needed on