bug#13928: Closing automake bug#13928 (bad interactions between 'subdir-object' option and automatic dependency tracking)

2015-01-06 Thread Stefano Lattarini
close 13928 thanks Reference: I've merged the latest patch series: into the 'minor' and 'master' branches, and the testsuite appears to be happy (or at least no more unhappy than before) on

bug#13928: [PATCH 1/4] deps: 'subdir-object' option now works when foo_SOURCES contains $(var)

2015-01-05 Thread Stefano Lattarini
missing when make is first we basically generate a temporary Makefile without these includes, and call 'make' on that Makefile. This fixes the serious bug bug#13928, which was an hard blocker to make the behavior mandated by the 'subdir-object' active by default (which we want

bug#13928: [PATCH 3/4] compile: don't place built object files in $(srcdir), ever ...

2015-01-05 Thread Stefano Lattarini
e should fix the second and last part of automake bug#13928. See also bug#16375 and bug#15293. * NEWS: Update. * bin/automake.in (handle_single_transform): Make sure object files and dependency-tracking makefile fragments coming from source like '$(srcdir)/foo.c' and '$(top_srcdi

bug#13928: [PATCH 0/4] Fix automake bug#13928

2015-01-05 Thread Stefano Lattarini
Stefano Lattarini (4): deps: 'subdir-object' option now works when foo_SOURCES contains $(var) tests: fix some bugs in an XFAILing test compile: don't place built object files in $(srcdir), ever ... deps: fix corner-case "make distclean" bug NEWS | 43 +++

bug#13928: [PATCH 4/4] deps: fix corner-case "make distclean" bug

2015-01-05 Thread Stefano Lattarini
get of any Makefile only removed the '.Po' makefile fragments included by it, rather than the whole '.deps' directory where such files resides. This change should be the last step in fixing automake bug#13928 for good. * bin/automake.in (handle_languages), lib/am/depend.a

bug#13928: [PATCH 2/4] tests: fix some bugs in an XFAILing test

2015-01-05 Thread Stefano Lattarini
* t/subobj-vpath-pr13928.sh: This one. The test would have failed (or hung!) even if the bug it was testing against were fixed. Signed-off-by: Stefano Lattarini --- t/subobj-vpath-pr13928.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/subobj-vpath-pr13928.sh b/t/sub

bug#13928: [PATCH] compile: don't place built object files in $(srcdir), ever ...

2015-01-04 Thread Stefano Lattarini
in a non-rewindable branch (that can't happen before Automake 1.16 is released anyway). +than in $(srcdir), and 'baz.o' in $(top_builddir) rather than in +$(top_srcdir). + +This was the second part of automake bug#13928. + ~

bug#13928: [PATCH] compile: don't place built object files in $(srcdir), ever ...

2015-01-02 Thread Stefano Lattarini
+than in $(srcdir), and 'baz.o' in $(top_builddir) rather than in +$(top_srcdir). + +This was the second part of automake bug#13928. + And thanks for tackling this! Wait to thank me, I'v

bug#13928: [PATCH] compile: don't place built object files in $(srcdir), ever ...

2015-01-02 Thread Stefano Lattarini
create 'foo.o' and 's/bar.o' $(builddir) rather s|'s/bar.o'|'s/bar.o' in| Thanks, will fix before merging this in a non-rewindable branch (that can't happen before Automake 1.16 is released anyway). +than in $(srcdir), and 'baz.

bug#13928: [PATCH] compile: don't place built object files in $(srcdir), ever ...

2015-01-02 Thread Eric Blake
> +then "make all" will create 'foo.o' and 's/bar.o' $(builddir) rather s|'s/bar.o'|'s/bar.o' in| > +than in $(srcdir), and 'baz.o' in $(top_builddir) rather than in > +$(top_srcdir). > + > +This was the second pa

bug#13928: [PATCH] compile: don't place built object files in $(srcdir), ever ...

2015-01-02 Thread Stefano Lattarini
e should fix the second and last part of automake bug#13928. See also bug#16375 and bug#15293. * NEWS: Update. * bin/automake.in (handle_single_transform): Make sure object files and dependency-tracking makefile fragments coming from source like '$(srcdir)/foo.c' and '$(top_srcdi

bug#13928: The 'subdir-object' option breaks makefiles where foo_SOURCES contains $(var)

2015-01-02 Thread Harlan Stenn
Stefano Lattarini writes: > On 01/02/2015 02:16 AM, Harlan Stenn wrote: > > Excellent timing, thanks! > > > > Now that ntp-4.2.8 is settling down, I'm looking to update our > > Makefile.am's to use subdir-objects, and it's not being fun. > > (An aside: I see that ntp still uses a recursive Makefile

bug#13928: The 'subdir-object' option breaks makefiles where foo_SOURCES contains $(var)

2015-01-02 Thread Stefano Lattarini
On 01/02/2015 02:16 AM, Harlan Stenn wrote: Excellent timing, thanks! Now that ntp-4.2.8 is settling down, I'm looking to update our Makefile.am's to use subdir-objects, and it's not being fun. (An aside: I see that ntp still uses a recursive Makefile setup. Given that you are about to mess wi

bug#13928: [PATCH] deps: 'subdir-object' option now works when foo_SOURCES contains $(var)

2015-01-01 Thread Stefano Lattarini
missing when make is first we basically generate a temporary Makefile without these includes, and call 'make' on that Makefile. This fixes the serious bug bug#13928, which was an hard blocker to make the behavior mandated by the 'subdir-object' active by default (which we want

bug#13928: The 'subdir-object' option breaks makefiles where foo_SOURCES contains $(var)

2015-01-01 Thread Harlan Stenn
Excellent timing, thanks! Now that ntp-4.2.8 is settling down, I'm looking to update our Makefile.am's to use subdir-objects, and it's not being fun. I may wait until 1.15 is released to continue this effort. H

bug#13928: The 'subdir-object' option breaks makefiles where foo_SOURCES contains $(var)

2015-01-01 Thread Stefano Lattarini
retitle 13928 foo_SOURCES containing unexpanded $(var) breaks with 'subdir-object' option active stop Reference: http://debbugs.gnu.org/13928 Hi Johan and everybody, sorry for the awful delay. On 07/05/2014 07:59 PM, Johan Kristensen wrote: Hi, What is the current status of this bug? [MEGA-

bug#13928: [PATCH] plans: enabling subdir-object by default is blocked on bug#13928

2014-07-05 Thread Johan Kristensen
Hi, What is the current status of this bug? I spent some time tracking down the reason for this bug, but I am totally new to the automake sources and what would be required for a patch to be acceptable. The problem is that when the dummy dependency-files is created by "./config.status" (by code fr

bug#13928: [PATCH] plans: enabling subdir-object by default is blocked on bug#13928

2014-04-22 Thread Stefano Lattarini
On 04/22/2014 09:11 AM, Bert Wesarg wrote: > Stefano, > > may it be possible to disable the 'subdir-object is the > default'-warning in the 1.14 release series than? We should have this > warning only active when we are sure that this bug is resolved. > I'd rather not take this step back, since th

bug#13928: [PATCH] plans: enabling subdir-object by default is blocked on bug#13928

2014-04-22 Thread Bert Wesarg
> @@ -5,6 +5,9 @@ We want to make the behaviour currently enabled by the > 'subdir-objects' > the default one, and in fact the *only* one, in Automake 2.0. > See automake bug#13378: <http://debbugs.gnu.org/13378>. > > +Sadly, **THIS IS IMPOSSIBLE** until automake

bug#13928: [PATCH] plans: enabling subdir-object by default is blocked on bug#13928

2014-04-21 Thread Stefano Lattarini
make the behaviour currently enabled by the 'subdir-objects' the default one, and in fact the *only* one, in Automake 2.0. See automake bug#13378: <http://debbugs.gnu.org/13378>. +Sadly, **THIS IS IMPOSSIBLE** until automake bug#13928 is resolved: +http://debbugs.gnu.org/cgi/b

bug#13928:

2013-08-05 Thread Shawn Webb
I'm hitting this bug as well. Are there any known workarounds? Thanks, Shawn Webb

bug#13928: VPATH issues with subdir-objects

2013-06-08 Thread Stefano Lattarini
[+cc automake-patches] Reference: <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13928> Hello everybody, sorry for the delay. On 11/03/2013 01:05 PM, Bert Wesarg wrote (more or less): > > But when I prefix a source file with '$(src)/' and use > subdir-objects then I g

bug#13928: VPATH issues with subdir-objects

2013-03-12 Thread Bert Wesarg
> Regarding the actual bug: without knowing much (yet!) about the relevant > Automake internals, I'm a bit surprised that > > src = src > foo_SOURCES = $(src)/foo.c > > fails with subdir-objects, but on the other hand > > src = src/foo.c > foo_SOURCES = $(src) > > seems to work just fine...

bug#13928: VPATH issues with subdir-objects

2013-03-12 Thread Nick Bowler
On 2013-03-11 23:27 +0100, Stefano Lattarini wrote: > On 03/11/2013 10:33 PM, Nick Bowler wrote: > > On 2013-03-11 21:55 +0100, Stefano Lattarini wrote: > > [...] > >> - from Automake 2.0 onward, only enable the automatic dependency > >> tracking if GNU make is used; we can thus assume the pr

bug#13928: VPATH issues with subdir-objects

2013-03-11 Thread Stefano Lattarini
On 03/11/2013 10:33 PM, Nick Bowler wrote: > On 2013-03-11 21:55 +0100, Stefano Lattarini wrote: > [...] >> - from Automake 2.0 onward, only enable the automatic dependency >> tracking if GNU make is used; we can thus assume the presence >> of the "-include" directive >> Actually, to be m

bug#13928: VPATH issues with subdir-objects (was: [PATCH 1/2] preproc: add support for relative names in included fragments)

2013-03-11 Thread Nick Bowler
On 2013-03-11 21:55 +0100, Stefano Lattarini wrote: [...] > - from Automake 2.0 onward, only enable the automatic dependency > tracking if GNU make is used; we can thus assume the presence > of the "-include" directive (which ignore non-existing files, > rather than punting), and its

bug#13928: VPATH issues with subdir-objects (was: [PATCH 1/2] preproc: add support for relative names in included fragments)

2013-03-11 Thread Stefano Lattarini
On 03/11/2013 08:45 PM, Bert Wesarg wrote: > [ Removing patches@ and 13524@ from Cc. ] > I think it's better if this discussion remains public. I'm re-adding automake-patches, and since you have apparently uncovered a new bug in automake, I'm also re-adding bug-automake, so that this discussion wi