Re: comment after trailing backslash inconsistent warning

2009-04-18 Thread Ralf Wildenhues
* Karl Berry wrote on Sun, Apr 19, 2009 at 12:10:31AM CEST: > The line numbers are probably off now since I made more > changes since sending the message, but the essential point is that it > complains about \ > # > at the end of man1_MANS definition (it is not present below), but does > not compla

Re: maintainer mode parallel make issue

2009-04-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ralf Wildenhues on 4/18/2009 4:27 PM: > Tangential to this issue, I think XFile::lock should warn resp. fail > also when parallel non-GNU make is used and exposes a locking issue. I agree; and the patch looks good to me. At any rate, my

Re: maintainer mode parallel make issue

2009-04-18 Thread Ralf Wildenhues
Tangential to this issue, I think XFile::lock should warn resp. fail also when parallel non-GNU make is used and exposes a locking issue. I'm not quite sure whether this can actually happen in practice, as for example BSD make does not update the target `Makefile' before updating regular targets, b

Re: comment after trailing backslash inconsistent warning

2009-04-18 Thread Karl Berry
There is no appendix to your message. As usual :). The line numbers are probably off now since I made more changes since sending the message, but the essential point is that it complains about \ # at the end of man1_MANS definition (it is not present below), but does not complain about the sa

Re: install-local target?

2009-04-18 Thread Karl Berry
you still need to specifically document something like this for users of your package: Good point. The issue doesn't actually arise in my particular case, but it would if we made a general feature. is it possible for your package to just use the uninstalled programs for this post

Re: debugging feature for recursive rules

2009-04-18 Thread Karl Berry
Very good. Minor comments: * Hard-Coded Install Paths::Installing to Hard-Coded Locations Wrong capitalization in the menu description this time, should be "hard-coded locations". +don't work as expected. Besides debug options provided by the Suggest inserting "the" after "Beside

Re: debugging feature for recursive rules

2009-04-18 Thread Ralf Wildenhues
* Karl Berry wrote on Sat, Apr 18, 2009 at 08:57:36PM CEST: > Try `make SHELL="/bin/bash -vx"', that should help for all rules that > > Good suggestion. Perhaps it should be added to the manual, if you > didn't already. You mean like this? Thanks, Ralf 2009-04-18 Ralf Wildenhues

Re: install-local target?

2009-04-18 Thread Ralf Wildenhues
Hi Karl, * Karl Berry wrote on Sat, Apr 18, 2009 at 08:57:36PM CEST: > - It isn't clear to me what should happen if the user typed > make install-data > or > make install-exec > only. Letting the hook run after one of them only seems clearly wrong. > > Yes, that would be

Re: install-local target?

2009-04-18 Thread Karl Berry
Hi Ralf, maybe install-hook would be better, Sure. - It isn't clear to me what should happen if the user typed make install-data or make install-exec only. Letting the hook run after one of them only seems clearly wrong. Yes, that would be wrong. Not running it

Re: debugging feature for recursive rules

2009-04-18 Thread Karl Berry
Try `make SHELL="/bin/bash -vx"', that should help for all rules that Good suggestion. Perhaps it should be added to the manual, if you didn't already. Thanks, Karl

Re: comment after trailing backslash inconsistent warning

2009-04-18 Thread Ralf Wildenhues
Hi Karl, * Karl Berry wrote on Sat, Apr 18, 2009 at 08:09:15PM CEST: > automake 1.10.2 complains about "comment after trailing backslash" > sometimes, but not every time. In the appended Makefile.am, I get > Makefile.am:23: comment following trailing backslash > which is true enough, but there a

comment after trailing backslash inconsistent warning

2009-04-18 Thread Karl Berry
automake 1.10.2 complains about "comment after trailing backslash" sometimes, but not every time. In the appended Makefile.am, I get Makefile.am:23: comment following trailing backslash which is true enough, but there are also comments after trailing backslashes at line 124 and line 108. And if